Page MenuHomePhabricator
Create Task
Maniphest T162481

Unwanted change of EducationProgram namespace
Closed, ResolvedPublic
Actions

Description

Hi all,
cswiki users realized that the namespace of EducationProgram extension has changed at all wikis which have this extension enabled to Education program regardless how it is set to Education program. This breaks significant amount of links at cswiki. They says that it surely was correct at Thursday April 06.

I've found only one EP-related change which is 17ded338cf53ed8d690ed2e412823ee03fb57146.

According to SAL the change was deployed today at 15:33 by @Reedy (15:33 reedy@tin: Synchronized wmf-config/CommonSettings.php: Remove EducationProgram config back compat (duration: 00m 41s)).

I have no idea how this change could be relevant to the namespace problem but I didn't find any other one (I've checked operations/mediawiki-config and mediawiki/extensions/EducationProgram repo).

Please fix this ASAP

Thank you in advance,
Martin Urbanec

Steps to reproduce

  1. Browse to cs.wikipedia.org
  2. Navigate to Special:Courses
  3. Click at any course
  4. Have a look at the namespace. It should be Kurzy but it is Education program

Details

SubjectRepoBranchLines +/-
Load ExtensionMessageFiles in PHP entry pointmediawiki/extensions/EducationProgrammaster+2 -0
Switch EducationProgram to extension.json for extension-listoperations/mediawiki-configmaster+2 -2
Load ExtensionMessageFiles in PHP entry pointmediawiki/extensions/EducationProgramwmf/1.29.0-wmf.19+2 -0
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm created this task.Apr 7 2017, 7:28 PM
Restricted Application added a project: User-Urbanecm. · View Herald TranscriptApr 7 2017, 7:28 PM
Restricted Application added subscribers: Base, Aklapper. · View Herald Transcript
Urbanecm triaged this task as High priority.Apr 7 2017, 7:28 PM
Urbanecm added a project: Regression.
Restricted Application added a subscriber: Dereckson. · View Herald TranscriptApr 7 2017, 7:28 PM
Reedy added a comment.EditedApr 7 2017, 7:33 PM

Did it break with the swap to .19?

https://gerrit.wikimedia.org/r/#/c/303384/

What's changed?

https://cs.wikipedia.org/w/api.php?action=query&meta=siteinfo&siprop=namespaces|namespacealiases

The cs version isn't showing... It's in English

Reedy added a subscriber: Legoktm.Apr 7 2017, 7:37 PM

A quick glance at extensions... It kinda looks like no extension that define namespaces, and have translations have actually been migrated to extension registration

@Legoktm Any ideas?

Urbanecm added a comment.EditedApr 7 2017, 7:38 PM

Yeah, the swap is a possibility of the change (when I look at the date, it broke today/yesterday).

Steps to reproduce

  1. Browse to cs.wikipedia.org
  2. Navigate to Special:Courses
  3. Click at any course
  4. Have a look at the namespace. It should be Kurzy but it is Education program
Urbanecm updated the task description. (Show Details)Apr 7 2017, 7:39 PM
Urbanecm updated the task description. (Show Details)

The cs version isn't showing... It's in English

Yeah, it's in English. But should be in Czech. It is defined in i18.ns file in the extension's repo (see https://github.com/wikimedia/mediawiki-extensions-EducationProgram/blob/master/EducationProgram.i18n.ns.php#L36).

Reedy added a comment.Apr 7 2017, 10:06 PM

Got it.

Going to fix this two different ways

gerritbot subscribed.Apr 7 2017, 10:08 PM

Change 347122 had a related patch set uploaded (by Reedy):
[operations/mediawiki-config@master] Switch EducationProgram to extension.json for extension-list

https://gerrit.wikimedia.org/r/347122

gerritbot added a project: Patch-For-Review.Apr 7 2017, 10:08 PM

Change 347123 had a related patch set uploaded (by Reedy):
[mediawiki/extensions/EducationProgram@master] Load ExtensionMessageFiles in PHP entry point

https://gerrit.wikimedia.org/r/347123

gerritbot added a comment.Apr 7 2017, 10:11 PM

Change 347124 had a related patch set uploaded (by Reedy):
[mediawiki/extensions/EducationProgram@wmf/1.29.0-wmf.19] Load ExtensionMessageFiles in PHP entry point

https://gerrit.wikimedia.org/r/347124

gerritbot added a comment.Apr 7 2017, 10:13 PM

Change 347124 merged by jenkins-bot:
[mediawiki/extensions/EducationProgram@wmf/1.29.0-wmf.19] Load ExtensionMessageFiles in PHP entry point

https://gerrit.wikimedia.org/r/347124

Stashbot subscribed.Apr 7 2017, 10:18 PM

Mentioned in SAL (#wikimedia-operations) [2017-04-07T22:18:26Z] <reedy@tin> Synchronized php-1.29.0-wmf.19/extensions/EducationProgram/EducationProgram.php: Load wgExtensionMessagesFiles in PHP entry point for mergeMessageLists T162481 (duration: 00m 49s)

Reedy added a comment.Apr 7 2017, 10:21 PM

Localisation Update should run in the next couple of hours. Which should fix the problem along with the merged/deployed change above

If not, I'll run scap manually myself tomorrow

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)).Apr 7 2017, 11:00 PM
Urbanecm added a comment.Apr 8 2017, 6:55 AM

Thank you!

Reedy added a comment.Apr 8 2017, 7:29 AM

LocalisationUpdate hasn't fixed it, has it?

Urbanecm added a comment.Apr 8 2017, 7:43 AM

Yes, the namespace is still in English...

gerritbot added a comment.Apr 8 2017, 8:32 AM

Change 347122 merged by jenkins-bot:
[operations/mediawiki-config@master] Switch EducationProgram to extension.json for extension-list

https://gerrit.wikimedia.org/r/347122

Stashbot added a comment.Apr 8 2017, 8:33 AM

Mentioned in SAL (#wikimedia-operations) [2017-04-08T08:33:38Z] <reedy@tin> Synchronized wmf-config/extension-list: T162481 (duration: 00m 40s)

Stashbot added a comment.Apr 8 2017, 8:34 AM

Mentioned in SAL (#wikimedia-operations) [2017-04-08T08:34:36Z] <reedy@tin> Synchronized wmf-config/CommonSettings.php: T162481 (duration: 00m 39s)

Stashbot added a comment.Apr 8 2017, 8:36 AM

Mentioned in SAL (#wikimedia-operations) [2017-04-08T08:36:25Z] <reedy@tin> Started scap: Rebuild EP l10n cache for namespace aliases T162481

Stashbot added a comment.Apr 8 2017, 9:55 AM

Mentioned in SAL (#wikimedia-operations) [2017-04-08T09:55:36Z] <reedy@tin> Finished scap: Rebuild EP l10n cache for namespace aliases T162481 (duration: 79m 11s)

Reedy closed this task as Resolved.Apr 8 2017, 9:56 AM
Reedy claimed this task.

Full scap has fixed this

https://cs.wikipedia.org/wiki/Kurz:Univerzita_Karlova/Advances_in_Immunology_(LS_2016-2017)

Urbanecm added a comment.Apr 8 2017, 10:16 AM

Thank you!

gerritbot added a comment.Apr 15 2017, 12:38 PM

Change 347123 merged by jenkins-bot:
[mediawiki/extensions/EducationProgram@master] Load ExtensionMessageFiles in PHP entry point

https://gerrit.wikimedia.org/r/347123

ReleaseTaggerBot edited projects, added MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)); removed MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)).Apr 15 2017, 1:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits