Data annotations should show on dashiki's tab layout just like they do in the vital signs layout
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Deploy browsers and reportcard | analytics/analytics.wikimedia.org | master | +5 K -1 K | |
| Improve annotations | analytics/dashiki | master | +112 -27 |
Related Objects
Related Objects
- Mentioned In
- rAAWOd5169c892ac9: Deploy browsers and reportcard
Event Timeline
Comment Actions
Just a quick FYI: here's a bit better way to show annotations, just modifying the style:
It's just an example, it should be thought through, with probably hover effects, but it seems better. This particular style was just:
width: 26px;
top: 0;
height: 100%;
opacity: 0.5;
background-color: lightgrey;
Comment Actions
@Milimetric
Sounds good! Will try that.
It seems to me like this way would work better for long-duration anomalies, as opposed to spikes, no?
Comment Actions
Hm, it might be tricky for ranges, because ranges right now are two annotations. So you'd have to do some CSS magic to get whatever you sandwich between two divs to stay there. I guess :after might work... can't know for sure without trying :)
For single-date annotations, maybe a dashed vertical line would work? You could do width: 0; border: 1px dashed grey; maybe
Comment Actions
Change 348227 had a related patch set uploaded (by Mforns):
[analytics/dashiki@master] Add annotations to tabs layout
Comment Actions
Change 350259 had a related patch set uploaded (by Mforns):
[analytics/analytics.wikimedia.org@master] Deploy browsers and reportcard
Comment Actions
Change 350259 merged by Mforns:
[analytics/analytics.wikimedia.org@master] Deploy browsers and reportcard
Comment Actions
Code has been deployed, but config can not be edited because of deployment freeze.
Will work on documentation in the meantime and leave this task in "ready to deploy" until deployment freeze finishes.
Comment Actions
Config is broken due to Dashiki extension being broken, fixes are being deployed after freeze.
Comment Actions
Improved the docs on Dashiki config: https://wikitech.wikimedia.org/wiki/Analytics/Systems/Dashiki#On-wiki_configuration