Page MenuHomePhabricator
Create Task
Maniphest T162494

Remove logic for Minerva desktop beta feature
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

A while back we added a configuration option so that a desktop beta feature exposing Minerva in desktop preferences under skin was available.

There hasn't been any progress on this in over a year and I don't see why we would need to put this through the beta feature process as it would be opt-in anyway.

I'd like us to remove this code.

Details

SubjectRepoBranchLines +/-
Remove Minerva desktop skin beta featuremediawiki/extensions/MobileFrontendmaster+2 -59
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Apr 7 2017, 9:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 7 2017, 9:05 PM
gerritbot subscribed.Apr 7 2017, 9:05 PM

Change 345484 had a related patch set uploaded (by Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Remove Minerva desktop skin beta feature

https://gerrit.wikimedia.org/r/345484

gerritbot added a project: Patch-For-Review.Apr 7 2017, 9:05 PM
Jdlrobson added a comment.Apr 7 2017, 9:05 PM

This work has been spun out of https://phabricator.wikimedia.org/T125588
I noticed it while working on that task.

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Apr 10 2017, 5:24 PM
• bmansurov moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.Apr 10 2017, 6:47 PM
Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Apr 12 2017, 11:16 PM
Jdlrobson triaged this task as Medium priority.Apr 13 2017, 7:03 PM
Jdlrobson set the point value for this task to 1.
Jdlrobson moved this task from Upcoming to Triaged but Future on the Web-Team-Backlog board.Apr 19 2017, 12:32 AM
Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Apr 26 2017, 3:24 AM
Jdlrobson added a project: Readers-Web-Kanbanana-Board-Old.Apr 29 2017, 12:02 AM
Jdlrobson moved this task from To Do to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Apr 29 2017, 12:06 AM
Jdlrobson moved this task from Upcoming to 2016-17 Q4 on the Web-Team-Backlog board.May 4 2017, 6:07 PM
pmiazga moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.May 4 2017, 8:02 PM
gerritbot added a comment.May 4 2017, 8:12 PM

Change 345484 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove Minerva desktop skin beta feature

https://gerrit.wikimedia.org/r/345484

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).May 4 2017, 9:00 PM
Jdlrobson assigned this task to phuedx.May 8 2017, 5:09 PM
Jdlrobson removed a project: Patch-For-Review.

This is a technical task and Sam has kindly said he will sign this off.

phuedx added a comment.May 8 2017, 5:39 PM

👍 Tested this on the Beta Cluster and it LGTM – the beta feature doesn't appear.

phuedx closed this task as Resolved.May 8 2017, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL