We have never handled this 100% correctly, but possibly should, if there are queries in the app for which it's necessary.
When you make an API request using a generator together with properties, the API result may signal to continue because there are more properties to retrieve for the pages so far, or because there are more pages from the generator, or both. From version 1.25 onwards, the API returns a batchcomplete element to indicate that all data for the current "batch" of pages has been returned. This can be useful to avoid building a combined result set for thousands of pages when using a generator together with prop modules that may themselves need continuation.
https://www.mediawiki.org/wiki/API:Query#batchcomplete
Do we have queries for which we expect the result set to be sufficiently large or complex that this will come into play?
Current classes using a generator query and potentially needing updating include:
- TitleSearchTask
- FullSearchArticlesTask
- GalleryCollectionFetchTask
- BecauseYouReadClient
- NearbyClient