Replace deprecated transaction.commit_manually in DjangoBannerLoader
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Ejegg
	Apr 7 2017, 11:02 PM

Description

LoadBannerImpressions2Aggregate.py:392: RemovedInDjango18Warning: commit_manually is deprecated in favor of set_autocommit

Details

	Subject	Repo	Branch	Lines +/-
	Update transactions for django 1.6+	wikimedia/fundraising/tools/DjangoBannerStats	master	+57 -43

Customize query in gerrit

Event Timeline

Ejegg created this task.Apr 7 2017, 11:02 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 7 2017, 11:02 PM

• ggellerman triaged this task as Medium priority.Apr 11 2017, 9:15 PM

• ggellerman set the point value for this task to 1.

• ggellerman moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.

Change 358419 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/tools/DjangoBannerStats@master] Update transactions for django 1.6

https://gerrit.wikimedia.org/r/358419

gerritbot added a project: Patch-For-Review.Jul 19 2017, 8:28 PM

Ejegg claimed this task.Aug 25 2017, 5:01 PM

Ejegg added a project: Fundraising Sprint Prank Seatbelt.

Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Prank Seatbelt board.

Ejegg moved this task from Pending Deployment to Review on the Fundraising Sprint Prank Seatbelt board.Aug 25 2017, 7:53 PM

Change 358419 merged by Mepps:
[wikimedia/fundraising/tools/DjangoBannerStats@master] Update transactions for django 1.6

https://gerrit.wikimedia.org/r/358419

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Prank Seatbelt board.Aug 28 2017, 4:58 PM

Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Prank Seatbelt board.Aug 29 2017, 9:02 PM

Working fine, with one fewer warning in the logs!

• DStrine added a project: Unplanned-Sprint-Work.Oct 18 2017, 9:35 PM

Replace deprecated transaction.commit_manually in DjangoBannerLoaderClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Event Timeline

Replace deprecated transaction.commit_manually in DjangoBannerLoader
Closed, ResolvedPublic1 Estimated Story Points
Actions