Page MenuHomePhabricator

Remove SiteLinkUsageLookup if no longer needed
Closed, ResolvedPublic

Description

We should remove Wikibase\Client\Usage\SiteLinkUsageLookup if it's no longer needed.

It is not used in the current code anywhere as it was replaced by SqlUsageTracker, but @daniel raised concerns over the potential future usage in other contexts.


It is currently only used in AffectedPagesFinderTest.php (and tests for itself).

The usage here could likely be replaced by something simpler / a mock / a different implementation.

Task

Evaluate if this class can be removed and mocks used, or if the mocks would be too complicated and thus the class should remain.

Details

Related Changes in Gerrit:

Event Timeline

Addshore subscribed.

It is currently only used in AffectedPagesFinderTest.php (and tests for itself).

The usage here could likely be replaced by something simpler / a mock / a different implementation.

Addshore lowered the priority of this task from Low to Lowest.Jan 30 2020, 8:05 AM
Addshore updated the task description. (Show Details)

Change 572845 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Drop SiteLinkUsageLookup

https://gerrit.wikimedia.org/r/572845

Ladsgroup subscribed.

Sorry I just picked this up because I needed something to do for half an hour until the deployment window.

Change 572845 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Drop SiteLinkUsageLookup

https://gerrit.wikimedia.org/r/572845