Page MenuHomePhabricator

Linter doesn't know "frame" alias on cswiki
Closed, InvalidPublic

Description

Linter bogus-image-options does recognize all other localized Czech Wikipedia aliases, but it doesn't recognize rám, which is an alternative for frame (or framed) option. But the option rám is not very special, it is correctly declared in MessagesCs.php as others.

Event Timeline

Legoktm subscribed.

That means Parsoid doesn't know about it for some reason :/

See below:

[subbu@earth parsoid] echo "[[Image:Foo.jpg|rám|abcd]]" | parse.js --lint --prefix cswiki > /dev/null
[subbu@earth parsoid] echo "[[Image:Foo.jpg|bogusrám|abcd]]" | parse.js --lint --prefix cswiki > /dev/null
[info/lint/bogus-image-options][cswiki/Main Page] {"type":"bogus-image-options","params":{"items":["bogusrám"]},"dsr":[0,31,null,null]}

Something else is going on. Should look at pages where this is being flagged.

See below for what is going on.

[subbu@earth parsoid] echo '[[Soubor:Foo.jpg|náhled|rám|bar]]' | parse.js --prefix cswiki --lint > /dev/null
[info/lint/bogus-image-options][cswiki/Main Page] {"type":"bogus-image-options","params":{"items":["rám"]},"dsr":[0,33,2,2]}
[subbu@earth parsoid] echo '[[Soubor:Foo.jpg|rám|náhled|bar]]' | parse.js --prefix cswiki --lint > /dev/null
[info/lint/bogus-image-options][cswiki/Main Page] {"type":"bogus-image-options","params":{"items":["náhled"]},"dsr":[0,33,2,2]}
[subbu@earth parsoid] echo '[[Soubor:Foo.jpg|rám|bar]]' | parse.js --prefix cswiki --lint > /dev/null

This is equivalent to the following on enwiki

[subbu@earth parsoid] echo '[[File:Foo.jpg|thumb|framed|bar]]' | parse.js --lint > /dev/null
[info/lint/bogus-image-options][enwiki/Main Page] {"type":"bogus-image-options","params":{"items":["framed"]},"dsr":[0,33,2,2]}
[subbu@earth parsoid] echo '[[File:Foo.jpg|framed|bar]]' | parse.js --lint > /dev/null
[subbu@earth parsoid] echo '[[File:Foo.jpg|framed|thumb|bar]]' | parse.js --lint > /dev/null
[info/lint/bogus-image-options][enwiki/Main Page] {"type":"bogus-image-options","params":{"items":["thumb"]},"dsr":[0,33,2,2]}

So, looks like the error is that you can only provide one of thumb or framed.

Please reopen if there is anything more to be done here.

ssastry triaged this task as Medium priority.