Page MenuHomePhabricator

[GOAL] Separate CSS in skin repositories into their own proper ResourceLoader modules
Open, Needs TriagePublic

Description

Some skins jumble their CSS together into one huge file. Ideally, this should be separated out and only loaded when needed.

A good example is Refreshed's main.css. Some CSS is specific to the Echo extension, while others are directly specific to viewing action=history, etc. See https://gerrit.wikimedia.org/r/#/c/347170/ for more information on how to create a similar patch, along with https://github.com/wikimedia/mediawiki/blob/master/resources/Resources.php to figure out how more easily which modules should be referenced in skin.json.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 10 2017, 12:26 AM
SamanthaNguyen renamed this task from [EPIC]Separate CSS into their own proper ResourceLoader modules to [GOAL] Separate CSS into their own proper ResourceLoader modules .Apr 10 2017, 12:26 AM
SamanthaNguyen renamed this task from [GOAL] Separate CSS into their own proper ResourceLoader modules to [GOAL] Separate CSS in skin repositories into their own proper ResourceLoader modules .
SamanthaNguyen added a project: Goal.
Isarra added a subscriber: Isarra.Apr 10 2017, 2:06 AM

It's very difficult to keep styles consistent across several files. We need better variables and mixins in each skin to define what the styles should actually be, generally, before splitting the files up becomes really tenable.

Also more work may need to be done to determine what the different modules should actually be, as many of the current core ones, especially for the skins themselves, are not split appropriately currently.