Page MenuHomePhabricator

MW 1.23.16 is not compatible with PHP 5.3
Closed, ResolvedPublic

Description

Short array syntax appeared in the 1.23.16 patch, which is not compatible with PHP 5.3.

@tstarling noticed and patched this, but this occurred after 1.23.16 was released, so 1.23.16 is effectively broken for PHP 5.3 users.

See https://www.mediawiki.org/wiki/Topic:Todfj3kynykwehky for a Support Desk thread about this.

Event Timeline

TTO created this task.Apr 10 2017, 1:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 10 2017, 1:38 AM
TTO renamed this task from MW 1.23.16 patch is not compatible with PHP 5.3 to MW 1.23.16 is not compatible with PHP 5.3.Apr 10 2017, 1:41 AM
TTO updated the task description. (Show Details)

Credit to @Erkan_Yilmaz who reported the issue on IRC. He also reported having an oddly corrupted XmlTypeCheck.php file, which didn't match the one in the 1.23.16 tarball which I downloaded at the time. It looks kind of like a bad conflict merge. See P5230, especially the wrong indenting and missing brace around line 357.

I wonder what needs to change to make it possible to run CI on security release tarballs. I understand this is currently not being done, contrary to the instructions at https://www.mediawiki.org/wiki/Release_checklist . The procedure suggested at T156445 has releases done before CI, and suggests only that the release engineer "Do some kind of testing???" before release.

demon added a comment.Apr 10 2017, 3:38 AM

I wonder what needs to change to make it possible to run CI on security release tarballs. I understand this is currently not being done, contrary to the instructions at https://www.mediawiki.org/wiki/Release_checklist . The procedure suggested at T156445 has releases done before CI, and suggests only that the release engineer "Do some kind of testing???" before release.

There's work in this area being done in the coming quarter. It should also reduce the time it takes us to spin out security releases.

TTO added a comment.Apr 11 2017, 10:17 AM

@demon, do you anticipate you'll be able to quickly push out a 1.23.17 update to address this for PHP 5.3 users?

demon added a comment.Apr 11 2017, 3:55 PM

@demon, do you anticipate you'll be able to quickly push out a 1.23.17 update to address this for PHP 5.3 users?

Already generated a 1.23.17 tag, creating tarball now

demon added a comment.EditedApr 11 2017, 5:04 PM

Files uploaded to releases.wm.o, just need to prep & send announcement and do the on-wiki updates.

demon added a comment.Apr 11 2017, 6:39 PM

I take that back, had to regenerate the tag and tarball, I hadn't bumped the version number yet.

demon closed this task as Resolved.Apr 11 2017, 6:54 PM
demon claimed this task.