Page MenuHomePhabricator

If you block an IP address as anonymous only, and then change it to a hardblock or vise versa, it is recorded as a completely new block
Closed, DuplicatePublic

Description

Hi,

I've noticed that there is a bug when blocking IP addresses and IP address range across multiple versions of MediaWiki. None of the Wikimedia Foundation projects seem to be having this issue. However, the Referata Wiki Farm (which runs MediaWiki version 1.25 globally), and thetestwiki.org (which runs the newest development version 1.29), have a bug where if you block an IP address as anonymous only, and then change the block to a hardblock, or vise versa, the software records it as a completely new block, not just a change in block settings. This means that the block list contains two different blocks for the same target with different parameters, and potentially even different expiry times. This issue does not occur for changing email/talk page access for either accounts or IP's. To cleary demonstrate this, I'll give this scenario:

  • An administrator by the name of WikiAdminUser blocks IP address 12.34.56.78 anonymous only for 2 weeks.
  • Either the same admin or another admin then modifies the block to be a hardblock and extends it to 1 month duration due to logged-in sock puppet abuse.
  • The software seems to be recording it as a brand-new block, which means that there are now two separate blocks for 12.34.56.78 defined in the block list, with different parameters and expiry times.
  • The IP address now has to be unblocked twice in order to clear the duplicate block, and then reblocked for one month as a hardblock

This problem seems to be occurring on many MediaWiki sites except WMF - with versions ranging from 1.25 to 1.28 to the master development 1.29

Event Timeline

Aklapper raised the priority of this task from High to Needs Triage.Apr 11 2017, 10:56 AM

Hi @Xauroflaux, thanks for taking the time to report this!
(It's unclear to me why this should be high priority though. :) )

Aklapper renamed this task from [BUG] IP address blocking problems to If you block an IP address as anonymous only, and then change it to a hardblock or vise versa, it is recorded as a completely new block.Apr 11 2017, 10:56 AM

Don't leave this as undetermined priority

Don't leave this as undetermined priority

@Xauroflaux: Do you plan to work on this task?

I hope to be able to if and when I figure out the problem. Right now I honestly don't know what's going on. I'd be able to decode it easier if it was an isolated issue, but because it is happening on multiple websites running different versions of MediaWiki it seems complicated.

Looks like this is the same issue that was reported in T157508