Page MenuHomePhabricator
Create Task
Maniphest T162645

New Flow topics are treated as, but not highlighted as, 'Page edits'
Closed, ResolvedPublic
Actions

Description

  1. On betalabs cawiki as a user with enabled RC filters, create a new topic on a Flow board.
  2. On RC page, select 'Page edits' filters - the newly created Flow topic will be present in the result set.

Note: it will be marked with 'N' as a new page which is misleading.

  1. Apply some highlighting color to the selected 'Page edits' filter - the new topic won't be highlighted.

Screen Shot 2017-04-10 at 4.15.55 PM.png (460×783 px, 96 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Classify Flow edits as mw-editmediawiki/extensions/Flowmaster+9 -3
Customize query in gerrit

Event Timeline

Etonkovidova created this task.Apr 10 2017, 11:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 10 2017, 11:17 PM
Catrope moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.Apr 10 2017, 11:46 PM
Catrope renamed this task from [betalabs] New Flow topic do not get highlighted as 'Page edits' to New Flow topics are treated as, but not highlighted as, 'Page edits' .Apr 10 2017, 11:54 PM
SBisson claimed this task.Apr 13 2017, 2:09 PM
SBisson moved this task from Ready for Pickup to In Development on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
gerritbot subscribed.Apr 13 2017, 2:10 PM

Change 348073 had a related patch set uploaded (by Sbisson):
[mediawiki/extensions/Flow@master] Classify Flow edits as mw-edit

https://gerrit.wikimedia.org/r/348073

gerritbot added a project: Patch-For-Review.Apr 13 2017, 2:10 PM
SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.Apr 13 2017, 2:21 PM
Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.Apr 13 2017, 5:11 PM
gerritbot added a comment.Apr 13 2017, 5:21 PM

Change 348073 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Classify Flow edits as mw-edit

https://gerrit.wikimedia.org/r/348073

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)).Apr 13 2017, 6:00 PM
Etonkovidova added a comment.Apr 13 2017, 11:38 PM

Checked the fix in betalabs - in the screenshot " N April 13 on Talk:ET1;..." is a new topic on Flow page is classified as 'Page edit' so the highlighting for 'Page edits' is applied correctly.

Screen Shot 2017-04-13 at 4.33.53 PM.png (450×723 px, 100 KB)

QA Recommendation: Resolve

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.Apr 13 2017, 11:38 PM
• jmatazzoni closed this task as Resolved.Apr 19 2017, 8:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits