Page MenuHomePhabricator

Template dialog's search results remain visible after selecting the template
Closed, ResolvedPublic1 Story Points

Description

Steps to reproduce:

  1. Be in a hurry.
  2. Type {{
  3. Type Done (the name of the template)
  4. Press Return
  5. Get this (in Safari 10):

or this (in Firefox 52):

Expected results:
The search results would disappear when a template has already been chosen.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 11 2017, 3:27 PM
Jdforrester-WMF triaged this task as Normal priority.Apr 11 2017, 7:03 PM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Possibly a Safari-only issue?

Change 347871 had a related patch set uploaded (by DLynch):
[mediawiki/extensions/VisualEditor@master] TemplatePlaceholderPage: abort pending template search after adding template

https://gerrit.wikimedia.org/r/347871

DLynch added a subscriber: DLynch.Apr 12 2017, 4:36 PM

I couldn't actually reproduce this, in Safari or anywhere else. However, I think I know what would be causing it, so that patch addresses the possible issue.

Change 347871 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] TemplatePlaceholderPage: abort pending template search after adding template

https://gerrit.wikimedia.org/r/347871

Jdforrester-WMF closed this task as Resolved.Apr 12 2017, 7:14 PM
Jdforrester-WMF assigned this task to DLynch.

Potentially fixed.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 12 2017, 7:14 PM