Page MenuHomePhabricator
Create Task
Maniphest T162716

Fix raw HTML tags breaking 1.29.0-wmf19+
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The new MediaWiki release is breaking templates on donatewiki:
https://donate.wikimedia.org/wiki/Special:FundraiserLandingPage?uselang=en&country=NL

We're causing releng tangible pain until this is fixed.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Kludge an exception to allow raw HTML in system messagesmediawiki/extensions/FundraiserLandingPagewmf/1.29.0-wmf.20+5 -0
Fix sanitization regexmediawiki/extensions/FundraiserLandingPagewmf/1.29.0-wmf.20+2 -2
Kludge an exception to allow raw HTML in system messagesmediawiki/extensions/FundraiserLandingPagewmf/1.29.0-wmf.19+5 -0
Kludge an exception to allow raw HTML in system messagesmediawiki/extensions/FundraiserLandingPagemaster+5 -0
Fix sanitization regexmediawiki/extensions/FundraiserLandingPagewmf/1.29.0-wmf.19+2 -2
Fix sanitization regexmediawiki/extensions/FundraiserLandingPagemaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

awight created this task.Apr 11 2017, 5:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 11 2017, 5:12 PM
awight triaged this task as Unbreak Now! priority.Apr 11 2017, 5:13 PM
awight added a project: Release-Engineering-Team.
Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptApr 11 2017, 5:13 PM
• demon renamed this task from Fix raw HTML tags breaking 1.29.0-wmf19 security release to Fix raw HTML tags breaking 1.29.0-wmf19+.Apr 11 2017, 5:16 PM

(minor tweak to title, it's not a security release, and donatewiki would be affected on all releases wmf.19 and above)

awight added a comment.Apr 11 2017, 6:03 PM

See https://phabricator.wikimedia.org/T156184

gerritbot subscribed.Apr 11 2017, 6:17 PM

Change 347656 had a related patch set uploaded (by Awight):
[mediawiki/extensions/FundraiserLandingPage@master] Fix sanitization regex

https://gerrit.wikimedia.org/r/347656

gerritbot added a project: Patch-For-Review.Apr 11 2017, 6:17 PM
gerritbot added a comment.Apr 11 2017, 6:20 PM

Change 347660 had a related patch set uploaded (by Awight):
[mediawiki/extensions/FundraiserLandingPage@master] Kludge an exception to allow raw HTML in system messages

https://gerrit.wikimedia.org/r/347660

• DStrine moved this task from Triage to Current Sprint and Completed in Q3 2016-17 on the Fundraising-Backlog board.Apr 11 2017, 7:31 PM
awight moved this task from Backlog to Review on the Fundraising Sprint Gondwanaland Reunification Engine board.Apr 11 2017, 7:53 PM
Pcoombe subscribed.Apr 12 2017, 11:33 AM
gerritbot added a comment.Apr 12 2017, 4:10 PM

Change 347656 merged by jenkins-bot:
[mediawiki/extensions/FundraiserLandingPage@master] Fix sanitization regex

https://gerrit.wikimedia.org/r/347656

gerritbot added a comment.Apr 12 2017, 4:10 PM

Change 347660 merged by jenkins-bot:
[mediawiki/extensions/FundraiserLandingPage@master] Kludge an exception to allow raw HTML in system messages

https://gerrit.wikimedia.org/r/347660

gerritbot added a comment.Apr 12 2017, 4:27 PM

Change 347863 had a related patch set uploaded (by Awight):
[mediawiki/extensions/FundraiserLandingPage@wmf/1.29.0-wmf.19] Fix sanitization regex

https://gerrit.wikimedia.org/r/347863

gerritbot added a comment.Apr 12 2017, 4:27 PM

Change 347864 had a related patch set uploaded (by Awight):
[mediawiki/extensions/FundraiserLandingPage@wmf/1.29.0-wmf.19] Kludge an exception to allow raw HTML in system messages

https://gerrit.wikimedia.org/r/347864

gerritbot added a comment.Apr 12 2017, 4:29 PM

Change 347865 had a related patch set uploaded (by Awight):
[mediawiki/extensions/FundraiserLandingPage@wmf/1.29.0-wmf.20] Fix sanitization regex

https://gerrit.wikimedia.org/r/347865

gerritbot added a comment.Apr 12 2017, 4:29 PM

Change 347863 merged by jenkins-bot:
[mediawiki/extensions/FundraiserLandingPage@wmf/1.29.0-wmf.19] Fix sanitization regex

https://gerrit.wikimedia.org/r/347863

gerritbot added a comment.Apr 12 2017, 4:29 PM

Change 347866 had a related patch set uploaded (by Awight):
[mediawiki/extensions/FundraiserLandingPage@wmf/1.29.0-wmf.20] Kludge an exception to allow raw HTML in system messages

https://gerrit.wikimedia.org/r/347866

gerritbot added a comment.Apr 12 2017, 4:29 PM

Change 347864 merged by jenkins-bot:
[mediawiki/extensions/FundraiserLandingPage@wmf/1.29.0-wmf.19] Kludge an exception to allow raw HTML in system messages

https://gerrit.wikimedia.org/r/347864

gerritbot added a comment.Apr 12 2017, 4:31 PM

Change 347865 merged by jenkins-bot:
[mediawiki/extensions/FundraiserLandingPage@wmf/1.29.0-wmf.20] Fix sanitization regex

https://gerrit.wikimedia.org/r/347865

gerritbot added a comment.Apr 12 2017, 4:31 PM

Change 347866 merged by jenkins-bot:
[mediawiki/extensions/FundraiserLandingPage@wmf/1.29.0-wmf.20] Kludge an exception to allow raw HTML in system messages

https://gerrit.wikimedia.org/r/347866

Stashbot subscribed.Apr 12 2017, 4:35 PM

Mentioned in SAL (#wikimedia-operations) [2017-04-12T16:35:20Z] <awight@tin> Synchronized php-1.29.0-wmf.19/extensions/FundraiserLandingPage: Fix for donatewiki T162716 (duration: 00m 48s)

Stashbot added a comment.Apr 12 2017, 4:37 PM

Mentioned in SAL (#wikimedia-operations) [2017-04-12T16:37:31Z] <awight@tin> Synchronized php-1.29.0-wmf.20/extensions/FundraiserLandingPage: Fix for donatewiki T162716 (duration: 00m 45s)

awight closed this task as Resolved.Apr 12 2017, 4:48 PM
awight moved this task from Review to Done on the Fundraising Sprint Gondwanaland Reunification Engine board.
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)).Apr 12 2017, 5:00 PM
Pcoombe mentioned this in T162300: donation page format error.Apr 12 2017, 5:06 PM
• DStrine moved this task from Current Sprint and Completed in Q3 2016-17 to Completed in Q4 2016-17 on the Fundraising-Backlog board.Apr 14 2017, 10:27 PM
• mmodell removed a subscriber: awight.Jun 22 2017, 9:32 PM
awight set the point value for this task to 2.Aug 29 2017, 9:48 PM
• DStrine added a project: Unplanned-Sprint-Work.Oct 17 2017, 7:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits