OOjs UI v0.21 places the expand button on the wrong side
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	WMDE-Fisch
	Apr 12 2017, 1:25 PM

Description

With the update of OOjs UI to v0.21 our expand button moves to the other side. This will go live next week if not fixed.

See attached screenshot from beta:

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix alignment of expand icon	mediawiki/extensions/RevisionSlider	master	+23 -68

Mentioned In: rERSL187ba30937b6: Fix alignment of expand icon
rERSLd18f2434dbd0: Fix alignment of expand icon
rERSL3150661a5791: Fix alignment of expand icon
rERSL26d33b6e0b5a: Fix alignment of expand icon

WMDE-Fisch triaged this task as High priority.Apr 12 2017, 1:26 PM

WMDE-Fisch moved this task from Proposed to Todo on the WMDE-TechWish board.

Another issue is that you have nested click targets which should always be avoided

Change 347874 had a related patch set uploaded (by Esanders):
[mediawiki/extensions/RevisionSlider@master] Fix alignment of expand icon

Change 347874 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Fix alignment of expand icon

@WMDE-Fisch Are you going to verify this and resolve that task when done?

Jdforrester-WMF claimed this task.

@Volker_E I can confirm that the issue is fixed, thanks again.

Thanks to @Esanders for the patch and to you, @WMDE-Fisch for raising it quickly.