Page MenuHomePhabricator

VE unit tests broken in jQ3, preventing upgrade
Closed, ResolvedPublic1 Story Points

Description

https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit-jessie/28122/consoleFull

16:24:23 FAILED TESTS:
16:24:23   ve.ui.MWWikitextStringTransferHandler
16:24:23     ✖ convert
16:24:23       Chrome 57.0.2987 (Linux 0.0.0)
16:24:23     afterEach failed on convert: Pending AJAX requests: 0 (active: 1)
16:24:23 
16:24:23   ve.init.mw.DesktopArticleTarget
16:24:23     ✖ compatibility
16:24:23       Chrome 57.0.2987 (Linux 0.0.0)
16:24:23     afterEach failed on compatibility: Pending AJAX requests: 0 (active: 1)
16:24:23 
16:24:23   ve.dm.Converter (Cite)
16:24:23     ✖ getModelFromDom
16:24:23       Chrome 57.0.2987 (Linux 0.0.0)
16:24:23     afterEach failed on getModelFromDom: Pending AJAX requests: 0 (active: 1)
16:24:23 
16:24:23     ✖ getDomFromModel
16:24:23       Chrome 57.0.2987 (Linux 0.0.0)
16:24:23     afterEach failed on getDomFromModel: Pending AJAX requests: 0 (active: 1)
16:24:23 
16:24:23   ve.dm.InternalList (Cite)
16:24:23     ✖ addNode/removeNode
16:24:23       Chrome 57.0.2987 (Linux 0.0.0)
16:24:23     afterEach failed on addNode/removeNode: Pending AJAX requests: 0 (active: 1)
16:24:23 
16:24:23     ✖ getItemInsertion
16:24:23       Chrome 57.0.2987 (Linux 0.0.0)
16:24:23     afterEach failed on getItemInsertion: Pending AJAX requests: 0 (active: 1)
16:24:23 
16:24:23     ✖ getUniqueListKey
16:24:23       Chrome 57.0.2987 (Linux 0.0.0)
16:24:23     afterEach failed on getUniqueListKey: Pending AJAX requests: 0 (active: 1)
16:24:23 
16:24:23   ve.dm.Transaction (Cite)
16:24:23     ✖ newFromDocumentInsertion with references
16:24:23       Chrome 57.0.2987 (Linux 0.0.0)

"Probably just a mock request somewhere that we don't wait for before calling done()"

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 12 2017, 4:46 PM

Change 348021 had a related patch set uploaded (by Krinkle; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] ve.test.utils: Don't try to write user options in test suites

https://gerrit.wikimedia.org/r/348021

Change 348021 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.test.utils: Don't try to write user options in test suites

https://gerrit.wikimedia.org/r/348021

Jdforrester-WMF set the point value for this task to 1.
Krinkle closed this task as Resolved.Apr 13 2017, 3:26 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 13 2017, 3:26 AM