Page MenuHomePhabricator

Improve deadlinks interface for multiple wikis
Closed, ResolvedPublic5 Estimated Story Points

Description

Now that Max's Bot is running on multiple wikis, we should make some improvements to the deadlinks interface on Tool Labs:

  • Add an "All projects" option to the project dropdown and make it the default
  • Add a checkbox for "Hide null edits" which would hide all records with Rev ID 0.
  • Fix "Total pages processed" so that it matches the project selection (currently it always includes all projects)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kaldari moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.
kaldari added a subscriber: Cyberpower678.
kaldari updated the task description. (Show Details)
kaldari updated the task description. (Show Details)
kaldari updated the task description. (Show Details)

@kaldari Could you make it a bit clearer what you mean by 'Fixed' and 'Processed'?

@Niharika: Right now our chart show 2 lines, one for fixed links and one for processed links. The log also shows both. The user should be able to set it to only show fixed links or only show processed links if they want. For example, Mark at Internet Archive only wants to see fixed links, but Max wants to see both.

Oops, that last comment isn't correct...

@Niharika: I revised the description. See if that makes more sense.

@kaldari It's very much possible for a page to have some fixed links and some not fixed links. Since log entries are by page, it's hard to segregate what counts as fixed and what doesn't.

How about we just add a filter for skipping entries with Revision ID 0? That's what Mark/Cyberpower seem to asking for. Revision ID being 0 indicates that there was something wrong. I'd rather have it in the view by default and have a checkbox for "skip error records" or something to skip them. Does that make sense?

@Niharika: That's fine with me. I think revision ID 0 happens whenever there is no actual edit to the page, which could be due to an error, or could be just because none of the links on the page were fixable. So I'm not sure exactly what you would call the filter. Maybe "Hide null edits" or something like that.

@Niharika: That's fine with me. I think revision ID 0 happens whenever there is no actual edit to the page, which could be due to an error, or could be just because none of the links on the page were fixable. So I'm not sure exactly what you would call the filter. Maybe "Hide null edits" or something like that.

If there is no actual edit to the page, I am not sure why the bot is logging it to the tool. Seems like a waste of space. @Cyberpower678 can you please add a safeguard against this at your end?

The addition of it is intentional. It does after all tell you how many links it tried to fix but couldn’t.

Cyberpower678
English Wikipedia Account Creation Team
English Wikipedia Administrator
Global User Renamer

I think @Cyberpower678 had mentioned that he wanted access to this data, although I'm not sure exactly why. @Cyberpower678 are you using that to figure out where to pick up if the bot dies?

I’ve so far been just using it as an overview of what the bot couldn’t fix for some reason. It makes the graph more reliable. But using that information is good too.

Cyberpower678
English Wikipedia Account Creation Team
English Wikipedia Administrator
Global User Renamer

kaldari set the point value for this task to 5.
kaldari moved this task from Needs Discussion to Up Next (June 3-21) on the Community-Tech board.