Page MenuHomePhabricator
Create Task
Maniphest T162838

Clicking in the gutter/margin area when editing with VE loses the text cursor (focus) from the editing surface
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

Clicking in the gutter/margin area when editing with VE loses the text cursor (focus) from the editing surface. Instead, it should place the text cursor at the beginning/end of the line of text.

These areas specifically:

image.png (961×1 px, 120 KB)

(This is with the patches for T162493 applied.)

Details

SubjectRepoBranchLines +/-
Make VisualEditor gutter area clickablemediawiki/skins/Timelessmaster+11 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Apr 12 2017, 9:28 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptApr 12 2017, 9:28 PM
gerritbot subscribed.Apr 12 2017, 9:30 PM

Change 347986 had a related patch set uploaded (by Bartosz Dziewoński):
[mediawiki/skins/Timeless@master] Make VisualEditor gutter area clickable

https://gerrit.wikimedia.org/r/347986

gerritbot added a project: Patch-For-Review.Apr 12 2017, 9:30 PM
Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Apr 12 2017, 9:49 PM
Jdforrester-WMF set the point value for this task to 0.
gerritbot added a comment.Apr 12 2017, 10:18 PM

Change 347986 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Make VisualEditor gutter area clickable

https://gerrit.wikimedia.org/r/347986

Jdforrester-WMF closed this task as Resolved.Apr 20 2017, 5:52 PM
Jdforrester-WMF assigned this task to matmarex.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF subscribed.

Resolved?

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 20 2017, 5:52 PM
matmarex added a subtask: T162493: .ve-ce-documentNode adds padding to content, expecting margin to be removed somewhere else.Apr 20 2017, 6:11 PM

Yeah, the remaining patch on T162493 still needs to be merged though.

matmarex closed subtask T162493: .ve-ce-documentNode adds padding to content, expecting margin to be removed somewhere else as Declined.May 12 2017, 4:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL