Page MenuHomePhabricator

Frameless buttons actually have a thin white frame
Closed, ResolvedPublic

Description

Frameless buttons actually have a thin white frame. This is visible when placed on a non-white background, for example the "Cancel" button in https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Albert_Einstein&action=edit&useskin=vector&ooui=1.

Originated in [[ https://phabricator.wikimedia.org/rGOJU99361c772c65baaf95de857d18e0dd8d00cc3e9c | “MediaWiki theme: Unify padding on ButtonElement” patch ]].

Evolution of the frameless button padding/focus:

v0.17.10v0.21.0v0.21.0 mod bg

Event Timeline

Change 348213 had a related patch set uploaded (by Bartosz Dziewoński):
[oojs/ui@master] MediaWiki theme: Remove thin white border on frameless buttons

https://gerrit.wikimedia.org/r/348213

Affecting deployed products. I think it should be at least high.

Change 348399 had a related patch set uploaded (by VolkerE):
[oojs/ui@master] MediaWiki theme: Fix border-color regression of frameless buttons

https://gerrit.wikimedia.org/r/348399

Change 348399 merged by jenkins-bot:
[oojs/ui@master] MediaWiki theme: Fix white border-color of frameless buttons

https://gerrit.wikimedia.org/r/348399

Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.