| WMDE-Fisch | |
| Apr 13 2017, 6:55 AM |
| F7521240: Screenshot ExandBar Border Missing.png | |
| Apr 13 2017, 6:55 AM |
Since the update to OOjs UI v0.21 theres a gap in the right border of the expandable bar of the RevisionSlider on RTL languages. This gap seems to be related to a negative margin applied see screenshot. Originally its a margin-left, but flipped due to RTL. When the negative margin is removed the border shows.
This will go live if not fixed till deployment next week.
Change 348399 had a related patch set uploaded (by VolkerE):
[oojs/ui@master] MediaWiki theme: Fix border-color regression of frameless buttons
Change 348399 merged by jenkins-bot:
[oojs/ui@master] MediaWiki theme: Fix white border-color of frameless buttons
@Jdforrester-WMF @Volker_E Thanks for addressing the issue!
Will the 0.21.1 version with that patch go into master before deployment today? Otherwise I would submit a temporary bugfix for the RevisionSlider so that the bug does not go live there.
There are no production deployments this week; I don't think we were going to do a 0.21.1 release this week, however, so a temporary bugfix for RevisionSlider would be needed for next week's deployment.
Change 348741 had a related patch set uploaded (by WMDE-Fisch):
[mediawiki/extensions/RevisionSlider@master] Temporary workaround for OOjs UI missing border bug
Change 348741 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Temporary workaround for OOjs UI missing border bug