Update deprecated hooks in Flagged Revs
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Reedy
	Apr 13 2017, 12:36 PM

Description

Use of ChangesListSpecialPageFilters hook (used in FlaggedRevsUIHooks::addHideReviewedFilter) was deprecated in MediaWiki 1.29 [Called from ChangesListSpecialPage::getCustomFilters in /srv/mediawiki/php-1.29.0-wmf.19/includes/specialpage/ChangesListSpecialPage.php at line 813]

and

Use of SpecialWatchlistQuery hook (used in FlaggedRevsUIHooks::modifyChangesListQuery) was deprecated in MediaWiki 1.23. [Called from SpecialWatchlist::runMainQueryHook in /srv/mediawiki/php-1.29.0-wmf.19/includes/specials/SpecialWatchlist.php at line 371]

The first one (at least) follows up T152754

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Update deprecated hooks regarding RecentChanges and Watchlist	mediawiki/extensions/FlaggedRevs	master	+38 -14

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	PRODUCTION ERROR	• Mattflaschen-WMF	T162881 Hooks: ChangesListSpecialPageFilters, SpecialRecentChangesFilters, SpecialRecentChangesQuery, SpecialWatchlistFilters and SpecialWatchlistQuery are deprecated
Resolved	PRODUCTION ERROR	• Mattflaschen-WMF	T162878 Update deprecated hooks in Flagged Revs
Resolved		matmarex	T161810 Update FlaggedRevs not to use deprecated EditPageBeforeEditChecks hook
Resolved	PRODUCTION ERROR	• Mattflaschen-WMF	T162902 Update FlaggedRevs not to use deprecated ChangesListSpecialPageFilters hook
Resolved	PRODUCTION ERROR	• Mattflaschen-WMF	T162903 Update FlaggedRevs not to use deprecated SpecialRecentChangesQuery hook
Resolved	PRODUCTION ERROR	• Mattflaschen-WMF	T162904 Update FlaggedRevs not to use deprecated SpecialWatchlistQuery hook
Resolved	PRODUCTION ERROR	Reedy	T162906 Update FlaggedRevs not to use deprecated Revision::getRawUser call
Resolved	PRODUCTION ERROR	Reedy	T162907 Update FlaggedRevs not to use deprecated Revision::getRawUserText call

Event Timeline

Reedy created this task.Apr 13 2017, 12:36 PM

Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald TranscriptApr 13 2017, 12:36 PM

Reedy mentioned this in T162879: Replace deprecated hook usage ChangesListSpecialPageFilters in WikimediaEvents.Apr 13 2017, 12:37 PM

Reedy added a project: Wikimedia-production-error.

Reedy added a parent task: T162881: Hooks: ChangesListSpecialPageFilters, SpecialRecentChangesFilters, SpecialRecentChangesQuery, SpecialWatchlistFilters and SpecialWatchlistQuery are deprecated.Apr 13 2017, 12:44 PM

Volans added a parent task: T162885: Fix MediaWiki deprecated calls in Wikimedia production, 2017-04-13.Apr 13 2017, 1:20 PM

Reedy closed this task as a duplicate of T161810: Update FlaggedRevs not to use deprecated EditPageBeforeEditChecks hook.Apr 13 2017, 3:45 PM

Jdforrester-WMF removed a parent task: T162885: Fix MediaWiki deprecated calls in Wikimedia production, 2017-04-13.Apr 13 2017, 4:17 PM

Jdforrester-WMF added subtasks: T161810: Update FlaggedRevs not to use deprecated EditPageBeforeEditChecks hook, T162902: Update FlaggedRevs not to use deprecated ChangesListSpecialPageFilters hook, T162903: Update FlaggedRevs not to use deprecated SpecialRecentChangesQuery hook, T162904: Update FlaggedRevs not to use deprecated SpecialWatchlistQuery hook, T162906: Update FlaggedRevs not to use deprecated Revision::getRawUser call, T162907: Update FlaggedRevs not to use deprecated Revision::getRawUserText call.

Not really a duplicate.

• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Apr 13 2017, 7:29 PM

Jdforrester-WMF closed subtask T162907: Update FlaggedRevs not to use deprecated Revision::getRawUserText call as Resolved.Apr 14 2017, 12:29 AM

Jdforrester-WMF closed subtask T162906: Update FlaggedRevs not to use deprecated Revision::getRawUser call as Resolved.

Change 348188 had a related patch set uploaded (by Mattflaschen):
[mediawiki/extensions/FlaggedRevs@master] Update deprecated hooks regarding RecentChanges and Watchlist

https://gerrit.wikimedia.org/r/348188

gerritbot added a project: Patch-For-Review.Apr 14 2017, 12:53 AM

Change 348188 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Update deprecated hooks regarding RecentChanges and Watchlist

https://gerrit.wikimedia.org/r/348188

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)).Apr 18 2017, 8:00 PM