Page MenuHomePhabricator

Update deprecated hooks in Flagged Revs
Closed, ResolvedPublic

Description

Use of ChangesListSpecialPageFilters hook (used in FlaggedRevsUIHooks::addHideReviewedFilter) was deprecated in MediaWiki 1.29 [Called from ChangesListSpecialPage::getCustomFilters in /srv/mediawiki/php-1.29.0-wmf.19/includes/specialpage/ChangesListSpecialPage.php at line 813]

and

Use of SpecialWatchlistQuery hook (used in FlaggedRevsUIHooks::modifyChangesListQuery) was deprecated in MediaWiki 1.23. [Called from SpecialWatchlist::runMainQueryHook in /srv/mediawiki/php-1.29.0-wmf.19/includes/specials/SpecialWatchlist.php at line 371]

The first one (at least) follows up T152754

Event Timeline

Reedy created this task.Apr 13 2017, 12:36 PM
Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald TranscriptApr 13 2017, 12:36 PM
Jdforrester-WMF reopened this task as Open.Apr 13 2017, 4:19 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Not really a duplicate.

Change 348188 had a related patch set uploaded (by Mattflaschen):
[mediawiki/extensions/FlaggedRevs@master] Update deprecated hooks regarding RecentChanges and Watchlist

https://gerrit.wikimedia.org/r/348188

Change 348188 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Update deprecated hooks regarding RecentChanges and Watchlist

https://gerrit.wikimedia.org/r/348188

Assuming all the child tickets are signed off, this is now Resolved.