Page MenuHomePhabricator

Regression: Categories do not show - broken by migration to ES5
Closed, ResolvedPublic

Description

Visit https://en.m.wikipedia.org/wiki/Dog?mobileaction=beta#/categories
Note the infinite spinner.

This is broken because the categories feature makes an API request to https://en.m.wikipedia.org/w/api.php?action=query&format=json&prop=categories&titles=Dog&clprop=hidden&cllimit=50 which returns an object

IT needs to pass formatversion=2 to be able to use forEach

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2017, 5:14 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 13 2017, 5:16 PM
Jdlrobson updated the task description. (Show Details)Apr 13 2017, 5:17 PM
ovasileva triaged this task as High priority.Apr 13 2017, 5:25 PM
ovasileva moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-95 board.
bmansurov moved this task from To Do to Doing on the Reading-Web-Sprint-95 board.
phuedx added a subscriber: phuedx.Apr 13 2017, 6:36 PM

It was a migration to ES5, right?

Jdlrobson renamed this task from Regression: Categories do not show - broken by migration to ES6 to Regression: Categories do not show - broken by migration to ES5.Apr 13 2017, 7:41 PM

Change 348128 had a related patch set uploaded (by Bmansurov):
[mediawiki/extensions/MobileFrontend@master] Retrieve categories using the API format version 2

https://gerrit.wikimedia.org/r/348128

Change 348128 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Retrieve categories using the API format version 2

https://gerrit.wikimedia.org/r/348128

Jdlrobson reassigned this task from bmansurov to ABorbaWMF.Apr 13 2017, 9:58 PM
Jdlrobson moved this task from Needs Code Review to Needs QA on the Reading-Web-Sprint-95 board.
Jdlrobson removed a project: Patch-For-Review.
Jdlrobson added a subscriber: bmansurov.

Categories should now be working again on the beta cluster. Hurrah!

Did some testing on the beta cluster. Categories are now appearing and they are clickable. There are two types of categories: Content-Based and Organizational. On the beta cluster, I only see categories listed under Organizational. There are no categories under Content-Based. I will take a look at this on production later.

Tested against https://en.wikipedia.beta.wmflabs.org/wiki/Dog

Jdlrobson closed this task as Resolved.Apr 17 2017, 5:27 PM

This is probably enough testing for a beta feature. It won't be on production until next Thursday (27th) so I'm going to call this done.