Page MenuHomePhabricator
Create Task
Maniphest T162991

test_proofwiki is failing with RuntimeError: Unsupported url
Closed, ResolvedPublic
Actions

Description

https://travis-ci.org/magul/pywikibot-core/jobs/222020334#L4513

======================================================================

ERROR: test_proofwiki (tests.site_detect_tests.StandardVersionSiteTestCase)

Test detection of MediaWiki sites for www.proofwiki.org.

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/magul/pywikibot-core/tests/site_detect_tests.py", line 63, in test_proofwiki

    self.assertSite('http://www.proofwiki.org/wiki/$1')

  File "/home/travis/build/magul/pywikibot-core/tests/site_detect_tests.py", line 37, in assertSite

    self.assertIsInstance(MWSite(url), MWSite)

  File "/home/travis/build/magul/pywikibot-core/pywikibot/site_detect.py", line 91, in __init__

    raise RuntimeError('Unsupported url: {0}'.format(self.fromurl))

RuntimeError: Unsupported url: https://proofwiki.org/wiki/

This is making most travis builds fail.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
site_detect.py: Detect database error from reponse.contentpywikibot/coremaster+6 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Dalba created this task.Apr 14 2017, 11:40 AM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptApr 14 2017, 11:40 AM
Dalba added a comment.Apr 14 2017, 11:51 AM

The HTML source code of https://proofwiki.org/:

<h1>Sorry! This site is experiencing technical difficulties.</h1><p>Try waiting a few minutes and reloading.</p><p><small>(Cannot access the database)</small></p><hr /><div style="margin: 1.5em">You can try searching via Google in the meantime.<br />
<small>Note that their indexes of our content may be out of date.</small>
</div>
<form method="get" action="//www.google.com/search" id="googlesearch">
	<input type="hidden" name="domains" value="https://proofwiki.org" />
	<input type="hidden" name="num" value="50" />
	<input type="hidden" name="ie" value="UTF-8" />
	<input type="hidden" name="oe" value="UTF-8" />
	<input type="text" name="q" size="31" maxlength="255" value="" />
	<input type="submit" name="btnG" value="Search" />
	<p>
		<label><input type="radio" name="sitesearch" value="https://proofwiki.org" checked="checked" />ProofWiki</label>
		<label><input type="radio" name="sitesearch" value="" />WWW</label>
	</p>
</form>

This is a mediawiki message (reportOutageHTML) shown after a database issue.

The test should be skipped in this situation, but the problem is that Mediawiki is responding with a 200 status code instead of 500 (server error).

There is an old task open opened for this at: T35917. We can manually process the page content and raise ServerError until that issue is resolved.

gerritbot subscribed.Apr 14 2017, 12:15 PM

Change 348211 had a related patch set uploaded (by Dalba):
[pywikibot/core@master] site_detect.py: Detect database error in reponse.content

https://gerrit.wikimedia.org/r/348211

gerritbot added a project: Patch-For-Review.Apr 14 2017, 12:15 PM
Dalba added a parent task: T35917: load.php should not return HTML if DB throws exception.Apr 14 2017, 12:33 PM
Dalba moved this task from Backlog to Upstream issues on the Pywikibot board.
Dalba removed a parent task: T35917: load.php should not return HTML if DB throws exception.
Dalba added a subtask: T35917: load.php should not return HTML if DB throws exception.
Xqt triaged this task as Medium priority.Apr 14 2017, 12:52 PM
gerritbot added a comment.Apr 14 2017, 12:55 PM

Change 348211 merged by jenkins-bot:
[pywikibot/core@master] site_detect.py: Detect database error from reponse.content

https://gerrit.wikimedia.org/r/348211

Xqt closed this task as Resolved.Apr 14 2017, 12:57 PM
Dalba added a parent task: T151145: Make Travis (and Appveyor) pass again.Apr 14 2017, 2:31 PM
Krinkle closed subtask T35917: load.php should not return HTML if DB throws exception as Resolved.Apr 15 2021, 5:32 PM
Xqt mentioned this in T331223: site_detect_tests fails on proofwiki when running on github.Mar 5 2023, 9:03 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 5 2023, 9:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits