Page MenuHomePhabricator

upload.py "Do you want to change this description?" which is empty
Closed, ResolvedPublic

Description

When it prints It is not possible to upload a file without a summary/description., it should imperatively ask a description instead of ask Do you want to change this description? which is empty.

python pwb.py upload -family:commons -lang:commons test
Invalid input filename given. Try again.
URL, file or directory where files are now: https://farm3.staticflickr.com/2895/33707537950_fc233821a0_o_d.jpg
The filename on the target wiki will default to: 33707537950_fc233821a0_o_d.jpg
Enter a better name, or press enter to accept: Dafodills_33707537950_fc233821a0_o_d.jpg
The suggested description is:

It is not possible to upload a file without a summary/description.
Do you want to change this description? ([Y]es, [n]o, [q]uit): y
Uploading file to commons:commons via API...
Reading file https://farm3.staticflickr.com/2895/33707537950_fc233821a0_o_d.jpg
Upload of Dafodills_33707537950_fc233821a0_o_d.jpg successful.

Event Timeline

Change 348485 had a related patch set uploaded (by Gerrit Patch Uploader; owner: Framawiki):
[pywikibot/core@master] upload.py: remove "Do you want to change this description?" when it's empty

https://gerrit.wikimedia.org/r/348485

The current implementation Shows
Do you want to change this description? ([Y]es, [n]o, [q]uit):
with automatic_quit enabled. Choice of 'q' leaves the script.

With your proposal, there is no ability to leave the script anymore (except the hard breaking Ctrl-C keyboard interrupt)

Change 348485 merged by jenkins-bot:
[pywikibot/core@master] upload.py: remove "Do you want to change this description?" when it's empty

https://gerrit.wikimedia.org/r/348485