[BUG] Article title is 'stuck' on showing a single title across all tabs after loading an article whilst offline
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	RHo
	Apr 17 2017, 3:32 PM

Description

Steps to reproduce

Whilst online load a few different articles in multiple tabs
Go offline (airplane mode)
Tap on a link in an article and open that article (either as a new tab or in the same tab). Note that the tab will open with that article title in the app bar over an 'article cannot be loaded while offline' message.
Go back online and switch to another article in the tab set

Expected

The article title does not appear for the other articles in the other tabs

Actual

The article title that was displayed when offline is stuck in the app bar no matter which tab or article is actually open.

See error here:
https://youtu.be/wkEz5LQcB20

Occurring on

Device = Nexus 5 (Android 6.0.1), Pixel (Android 7.1.2)
Version = Wikipedia 2.5.195-alpha-2017-06-05

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Remove the page title left behind when a page load fails	apps/android/wikipedia	master	+17 -11

Customize query in gerrit

Related Objects

Mentioned In: T173756: Article names remain on top bar in some cases

Event Timeline

RHo created this task.Apr 17 2017, 3:32 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2017, 3:32 PM

• NHarateh_WMF moved this task from Needs Triage to Bug Backlog on the Wikipedia-Android-App-Backlog board.Apr 19 2017, 3:25 PM

RHo updated the task description. (Show Details)Jun 16 2017, 9:57 AM

@Dbrant – this is still occurring on the latest prod release and in Alpha and quite noticeable whenever anyone switches from offline back to online since the article title bar continues to show the incorrect article as long as the article stack is open.

RHo mentioned this in T173756: Article names remain on top bar in some cases.Aug 23 2017, 7:12 PM

Kaartic reopened this task as Open.Aug 24 2017, 4:48 PM

Kaartic closed this task as a duplicate of T173756: Article names remain on top bar in some cases.

Kaartic merged a task: T173756: Article names remain on top bar in some cases.Aug 24 2017, 4:50 PM

Kaartic subscribed.

Change 373883 had a related patch set uploaded (by Kaartic; owner: Kaartic):
[apps/android/wikipedia@master] Remove the page title left behind when a page load fails

https://gerrit.wikimedia.org/r/373883

Restricted Application added a subscriber: jeblad. · View Herald TranscriptAug 25 2017, 1:03 PM

gerritbot added a project: Patch-For-Review.Aug 25 2017, 1:03 PM

jeblad unsubscribed.Aug 25 2017, 10:08 PM

Change 373883 merged by jenkins-bot:
[apps/android/wikipedia@master] Remove the page title left behind when a page load fails

https://gerrit.wikimedia.org/r/373883

Dbrant edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩); removed Wikipedia-Android-App-Backlog.Aug 29 2017, 3:37 PM

Dbrant moved this task from To Do to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩) board.

Tested on a Nexus 4 with Android 5.1 and a Pixel with Android 7.1.1 on 2.6.203-alpha-2017-08-29

Could not reproduce the issue on my end.

Dbrant moved this task from Design Signoff to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩) board.Sep 11 2017, 2:56 PM

Dbrant closed this task as Resolved.Sep 11 2017, 2:57 PM

Dbrant claimed this task.

[BUG] Article title is 'stuck' on showing a single title across all tabs after loading an article whilst offlineClosed, ResolvedPublicActions