⚓ T163142 Buttons in the toolbar should be actual tools

Subject	Repo	Branch	Lines +/-
Update OOUI to v0.32.0	mediawiki/core	master	+429 -270
[BREAKING CHANGE] Toolbar: Remove support for non-tool buttons	oojs/ui	master	+23 -217
Update OOUI to v0.31.4	mediawiki/core	master	+523 -129
Replace the save button with a save tool	mediawiki/extensions/VisualEditor	master	+165 -108
Convert publish button to a tool	mediawiki/extensions/ContentTranslation	master	+65 -22
Support flagged buttons in the toolbar	oojs/ui	master	+295 -79

		Status	Subtype	Assigned	Task
		Open		None	T101995 Improvements to the toolbar system
		Resolved		Esanders	T163142 Buttons in the toolbar should be actual tools

Jdforrester-WMF created this task.Apr 17 2017, 8:00 PM

Jdforrester-WMF mentioned this in T160794: Make having a ButtonGroupWidget in the actionsToolbar not look terrible.

…instead of links? Is this Accessibility related?

Instead of OO.ui.ButtonWidget's.

Volker_E moved this task from Backlog to Next-up on the OOUI board.Feb 2 2018, 2:17 AM

Also the even hackier button groups with tool groups in toolbars: T189338

Esanders added a project: VisualEditor.Mar 20 2019, 4:33 PM

Change 497846 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] WIP: Support flagged buttons in the toolbar

https://gerrit.wikimedia.org/r/497846

gerritbot added a project: Patch-For-Review.Mar 20 2019, 7:12 PM

JTannerWMF edited projects, added VisualEditor (Current work); removed VisualEditor.Mar 26 2019, 3:28 PM

JTannerWMF moved this task from Incoming to In progress on the VisualEditor (Current work) board.

Esanders claimed this task.Mar 28 2019, 4:16 PM

Esanders removed Esanders as the assignee of this task.

Esanders claimed this task.Mar 28 2019, 6:19 PM

Esanders moved this task from In progress to Code review on the VisualEditor (Current work) board.Apr 1 2019, 4:52 PM

Volker_E moved this task from Next-up to Reviewing on the OOUI board.Apr 3 2019, 3:09 AM

Change 497846 merged by jenkins-bot:
[oojs/ui@master] Support flagged buttons in the toolbar

https://gerrit.wikimedia.org/r/497846

• Petar.petkovic removed a project: Patch-For-Review.Apr 15 2019, 5:49 AM

Esanders moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Apr 15 2019, 12:18 PM

Change 504214 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Replace the save button with a save tool

https://gerrit.wikimedia.org/r/504214

gerritbot added a project: Patch-For-Review.Apr 16 2019, 12:24 PM

Change 504473 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.31.4

https://gerrit.wikimedia.org/r/504473

Change 504473 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.31.4

https://gerrit.wikimedia.org/r/504473

Volker_E moved this task from Reviewing to OOUI-0.31.4 on the OOUI board.Apr 17 2019, 5:18 AM

Volker_E edited projects, added OOUI (OOUI-0.31.4); removed OOUI.

Volker_E removed a project: Patch-For-Review.

Volker_E removed a subscriber: gerritbot.

Change 506402 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/ContentTranslation@master] Convert publish button to a tool

https://gerrit.wikimedia.org/r/506402

gerritbot added a project: Patch-For-Review.Apr 25 2019, 12:55 PM

Volker_E added a project: ContentTranslation.Apr 27 2019, 7:58 AM

Change 506402 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Convert publish button to a tool

https://gerrit.wikimedia.org/r/506402

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 29 2019, 12:00 PM

Change 504214 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Replace the save button with a save tool

https://gerrit.wikimedia.org/r/504214

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.4; 2019-05-07); removed MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 30 2019, 8:00 PM

This is implemented in OOUI, and fixed in VE and CX which are the only users.

We can now remove the button-in-toolbar CSS hacks.

Change 508954 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Remove button-in-toolbar code