Page MenuHomePhabricator

dbtree: don't return 200 on error pages
Closed, ResolvedPublic


T162976 was partially caused by dbtree returning an error (about failed database connection) together with HTTP status 200, which resulted in varnish caching of the error page.

as a follow-up task, dbtree should not use 200 with error pages but an appropriate 5xx server error if the database connection fails.

Event Timeline

Dzahn created this task.Apr 17 2017, 8:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2017, 8:01 PM
jcrespo moved this task from Triage to Backlog (help welcome) on the DBA board.Apr 27 2017, 9:38 AM
MoritzMuehlenhoff triaged this task as Medium priority.May 10 2017, 8:58 PM

Change 353388 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/software/dbtree@master] return HTTP 503 if database connection fails

Change 353388 merged by Dzahn:
[operations/software/dbtree@master] return HTTP 503 if database connection fails

Mentioned in SAL (#wikimedia-operations) [2017-05-18T20:44:24Z] <mutante> terbium / dbtree - deploying gerrit:353388 (sudo -u mwdeploy git pull origin in /srv/dbtree) (T163143)