Page MenuHomePhabricator
Create Task
Maniphest T163267

[Regression pre-wmf.21] Cite dialog is not opening, "Uncaught TypeError: Cannot read property 'keyedNodes' of undefined" in the console
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Click on Cite from Toolbar

Cite dialog does not open, and in the console following error appears:
Uncaught TypeError: Cannot read property 'keyedNodes' of undefined

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
MWReferenceNode: Don't try to remove from the internal list if it's not addedmediawiki/extensions/Citemaster+4 -0
Only remove from internal list if unroot from correct documentmediawiki/extensions/Citemaster+6 -4
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Apr 18 2017, 9:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 18 2017, 9:30 PM
Jdforrester-WMF triaged this task as High priority.Apr 19 2017, 10:42 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF added projects: Cite, VisualEditor-MediaWiki-References.
DLynch added subscribers: dchan, DLynch.EditedApr 20 2017, 7:25 AM

Looks very strongly like a side-effect of @dchan's 719f8c6673093c37b44e0e11a00db7ea6941b5cd.

Specifically, Cite's referencenode really doesn't expect to be unrooted before it has been added to the internal list in the first place.

gerritbot subscribed.Apr 20 2017, 7:36 AM

Change 349161 had a related patch set uploaded (by DLynch):
[mediawiki/extensions/Cite@master] MWReferenceNode: Don't try to remove from the internal list if it's not added

https://gerrit.wikimedia.org/r/349161

gerritbot added a project: Patch-For-Review.Apr 20 2017, 7:36 AM
gerritbot added a comment.Apr 20 2017, 3:16 PM

Change 349226 had a related patch set uploaded (by Esanders):
[mediawiki/extensions/Cite@master] Only remove from internal list if unroot from correct document

https://gerrit.wikimedia.org/r/349226

Esanders subscribed.Apr 20 2017, 3:16 PM

I went for a fix a little further up the stack..

gerritbot added a comment.Apr 20 2017, 5:32 PM

Change 349226 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Only remove from internal list if unroot from correct document

https://gerrit.wikimedia.org/r/349226

gerritbot added a comment.Apr 20 2017, 5:35 PM

Change 349161 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] MWReferenceNode: Don't try to remove from the internal list if it's not added

https://gerrit.wikimedia.org/r/349161

Jdforrester-WMF closed this task as Resolved.Apr 20 2017, 5:44 PM
Jdforrester-WMF assigned this task to DLynch.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 20 2017, 5:44 PM
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)).Apr 20 2017, 6:00 PM
Ryasmeen edited projects, added Verified; removed Patch-For-Review.Apr 20 2017, 11:39 PM
Ryasmeen added a project: Verified-in-Phase0.Apr 26 2017, 8:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits