- On RC page with filters, click the 'Highlight button' but do not make any color selection or any other actions.
- Two things happen:
- the results set underneath the drop-down filter selection panel will contract a little bit which might give an impression that the result set is in some way affected by clicking 'Highlight results'
- the bullet points that are displayed blue will change to blank, empty circles
Description
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| RCFilters UI: Unify li bullets with and without highlights | mediawiki/core | master | +11 -3 |
Event Timeline
Change 349102 had a related patch set uploaded (by Mooeypoo):
[mediawiki/core@master] RCFilters UI: Unify li bullets with and without highlights
The fix here fixes #3: https://gerrit.wikimedia.org/r/#/c/349102/
#4 is by design... The design specified that for highlighting, the "normal" bullets are white circles.
Pinging @Pginer-WMF for confirmation or change
This also seems to be the same way that the prototype behaves: http://pauginer.github.io/prototypes/edit-review/highlight-changes/index.html
The big difference is the lines "moving" between being "regular" bullets and white-circles, but the fix above corrects that (the *bullets* themselves still shift very very slightly, but the text and lines themselves are no longer moving with the above fix)
I moved this to 'needs review' and will continue up the chain (qa/etc) without fixing #4 unless there are objections...?
Change 349102 merged by jenkins-bot:
[mediawiki/core@master] RCFilters UI: Unify li bullets with and without highlights
Yes, this is intentional. We didn't want the blue color of default bullet points to create confusion with those colors resulting from highlight.
