Page MenuHomePhabricator
Create Task
Maniphest T163404

[Regression pre-.21] Categories input in VisualEditor "Page options" dialog has weird internal spacing
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Categories input in VisualEditor "Page options" dialog has weird internal spacing.

image.png (1×1 px, 321 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
MWCategoryItemWidget: remove DraggableElement's paddingmediawiki/extensions/VisualEditormaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Apr 20 2017, 12:19 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptApr 20 2017, 12:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matmarex added subscribers: DLynch, Volker_E.Apr 20 2017, 12:23 AM

This is probably a regression from rGOJU9d1612ace56f: DraggableElement: Only apply focus when widget is not disabled in OOjs UI (which fixed the 'padding' rule added in 09a82ed15/f6be5b2f that previously was ignored). I think @DLynch said he's looking into it, filing this just so that it's not forgotten.

Jdforrester-WMF triaged this task as High priority.Apr 20 2017, 12:49 AM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
DLynch merged a task: T163414: Category options padding messed up by OOjs UI changes.Apr 20 2017, 7:04 AM
DLynch added a subscriber: gerritbot.
gerritbot added a comment.Apr 20 2017, 7:05 AM

Change 349157 had a related patch set uploaded (by DLynch):
[mediawiki/extensions/VisualEditor@master] MWCategoryItemWidget: remove DraggableElement's padding

https://gerrit.wikimedia.org/r/349157

gerritbot added a project: Patch-For-Review.Apr 20 2017, 7:05 AM
gerritbot added a comment.Apr 20 2017, 3:23 PM

Change 349157 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWCategoryItemWidget: remove DraggableElement's padding

https://gerrit.wikimedia.org/r/349157

Jdforrester-WMF closed this task as Resolved.Apr 20 2017, 3:51 PM
Jdforrester-WMF assigned this task to DLynch.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 20 2017, 3:51 PM
Jdforrester-WMF renamed this task from Categories input in VisualEditor "Page options" dialog has weird internal spacing to [Regression pre-.21] Categories input in VisualEditor "Page options" dialog has weird internal spacing.Apr 20 2017, 3:51 PM
Jdforrester-WMF removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)).Apr 20 2017, 4:00 PM
Ryasmeen added a project: Verified.Apr 25 2017, 7:48 PM
Ryasmeen added a project: Verified-in-Phase0.Apr 26 2017, 8:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits