Page MenuHomePhabricator

[Regression pre-.21] Categories input in VisualEditor "Page options" dialog has weird internal spacing
Closed, ResolvedPublic1 Story Points

Description

Categories input in VisualEditor "Page options" dialog has weird internal spacing.

Event Timeline

Restricted Application added a project: VisualEditor. · View Herald TranscriptApr 20 2017, 12:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

This is probably a regression from rGOJU9d1612ace56f: DraggableElement: Only apply focus when widget is not disabled in OOjs UI (which fixed the 'padding' rule added in 09a82ed15/f6be5b2f that previously was ignored). I think @DLynch said he's looking into it, filing this just so that it's not forgotten.

Jdforrester-WMF triaged this task as High priority.Apr 20 2017, 12:49 AM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

Change 349157 had a related patch set uploaded (by DLynch):
[mediawiki/extensions/VisualEditor@master] MWCategoryItemWidget: remove DraggableElement's padding

https://gerrit.wikimedia.org/r/349157

Change 349157 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWCategoryItemWidget: remove DraggableElement's padding

https://gerrit.wikimedia.org/r/349157

Jdforrester-WMF closed this task as Resolved.Apr 20 2017, 3:51 PM
Jdforrester-WMF assigned this task to DLynch.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 20 2017, 3:51 PM
Jdforrester-WMF renamed this task from Categories input in VisualEditor "Page options" dialog has weird internal spacing to [Regression pre-.21] Categories input in VisualEditor "Page options" dialog has weird internal spacing.Apr 20 2017, 3:51 PM
Jdforrester-WMF removed a project: Patch-For-Review.