Page MenuHomePhabricator
Create Task
Maniphest T163436

Pointer line end missing when in alternate SliderView
Closed, ResolvedPublic
Actions

Description

When the pointer lines connect to a revision bar pointing down that uses the whole height - the colored end of the line does not show. See blue pointer line in the screen shot below:

RevsiionSlider Pointer Line End.png (770×1 px, 78 KB)

Details

SubjectRepoBranchLines +/-
Let revision bars leave space for the pointer line end bordermediawiki/extensions/RevisionSlidermaster+25 -3
Customize query in gerrit

Related Objects

Event Timeline

WMDE-Fisch created this task.Apr 20 2017, 12:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2017, 12:11 PM
WMDE-Fisch moved this task from Proposed to Todo on the WMDE-TechWish board.Apr 20 2017, 12:12 PM
gerritbot subscribed.Apr 20 2017, 1:24 PM

Change 349216 had a related patch set uploaded (by WMDE-Fisch):
[mediawiki/extensions/RevisionSlider@master] Let revision bars leave space for the pointer line end border

https://gerrit.wikimedia.org/r/349216

gerritbot added a project: Patch-For-Review.Apr 20 2017, 1:24 PM
WMDE-Fisch claimed this task.Apr 20 2017, 1:24 PM
WMDE-Fisch moved this task from Todo to Currently in sprint on the WMDE-TechWish board.
WMDE-Fisch mentioned this in rERSL8830b6f5f349: Let revision bars leave space for the pointer line end border.Apr 20 2017, 1:27 PM
WMDE-Fisch mentioned this in rERSLf4a0e2092814: Let revision bars leave space for the pointer line end border.Apr 20 2017, 1:58 PM
Tobi_WMDE_SW moved this task from Incoming to Revision Slider on the TCB-Team (now WMDE-TechWish) board.Apr 25 2017, 10:13 AM
WMDE-Fisch mentioned this in rERSL72d19630add8: Let revision bars leave space for the pointer line end border.Apr 25 2017, 1:46 PM
gerritbot added a comment.Apr 27 2017, 10:32 AM

Change 349216 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Let revision bars leave space for the pointer line end border

https://gerrit.wikimedia.org/r/349216

WMDE-Fisch moved this task from Currently in sprint to Done on the WMDE-TechWish board.Apr 27 2017, 10:47 AM
ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).Apr 27 2017, 11:00 AM
Lea_WMDE moved this task from Incoming to Doing on the Revision-Slider board.May 8 2017, 12:19 PM
Tobi_WMDE_SW closed this task as Resolved.May 30 2017, 10:20 AM
Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-TechWish board.Jun 6 2017, 2:34 PM
Tobi_WMDE_SW removed a project: WMDE-TechWish.Jun 7 2017, 11:59 AM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 3:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL