Page MenuHomePhabricator

Paypal recurring donations missing contribution_tracking link since 2017-04-10
Closed, ResolvedPublic

Description

I was checking on rates and noticed that while there are plenty of entries in contribution_tracking with the method 'rpaypal', none seem to map to any completed donations since 2017-04-10.

Tried to set up a recurring donation from a banner today, and it looked to be a success. I can find it in both contribution_tracking (id 47044718) and Civi (id 23098766) but there is no link between them.

This is a problem because we would like to do more recurring tests but can't see the results.

Event Timeline

Ejegg subscribed.

Darn, sounds like a regression in our new recurring normalization flow. We should pull this into sprint!

Based on the Express Checkout pre-test it seems this isn't a problem there, only on legacy Paypal

@jrobell @spatton @TSkaff
FYI, we should hold off on doing any tests related to recurring for now because Paypal recurring donations aren't properly trackable. I think this would have affected the later stages of the Netherlands frequency slider test, although it's pretty clear that wasn't making much difference anyway.

Change 349254 had a related patch set uploaded (by Ejegg):
[wikimedia/fundraising/crm@master] Always update c_t table for recurring

https://gerrit.wikimedia.org/r/349254

Change 349495 had a related patch set uploaded (by Ejegg):
[wikimedia/fundraising/crm@master] Backfill missing contribution_tracking links

https://gerrit.wikimedia.org/r/349495

Thanks @Ejegg. If we can backfill the data too that would be fantastic!

Change 349254 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Always update c_t table for initial recurring

https://gerrit.wikimedia.org/r/349254

Change 349495 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Backfill missing contribution_tracking links

https://gerrit.wikimedia.org/r/349495

Hi @Pcoombe, the fix is deployed and I ran the backfill script. There had been about 20,000 recurring paypal contributions since 4/10 without links in the c_t table. The backfill script tagged about 9,000 of them. I /think/ that means the other 11,000 were non-initial donations, and that the subscriber's c_t row already pointed to the initial contribution.

I see 9 new c_t rows with links to recurring paypal donations in the last 16 hours. Should we expect more?

Wonderful, thank you @Ejegg! 9 in the last 16 hours sounds plausible, we're only up in Spain at the moment and unfortunately we don't get too many of these.