Page MenuHomePhabricator

No JS causes "Could not load no JS notice!" overlay in 10h16 skin
Closed, InvalidPublic

Description

When disabling the execution of JavaScript and using the donation application with the skin "10h16", an overlay is being displayed. The overlay should contain a notice asking the user to enable JavaScript. Currently it shows a notice saying that the notice could not be loaded.

The page should look like other error pages (e. g. page not found). As in the "cat17" skin, the message should say:


JavaScript deaktiviert!
Diese Seite benötigt JavaScript um richtig zu funktionieren. Leider haben Sie dieses deaktiviert.
Finden Sie heraus wie Sie JavaScript aktivieren können um zu spenden oder Mitglied zu werden.


Acceptance Criteria:

  • The above defined message is displayed when loading a page.
  • Pages that do not need JavaScript to work (static content pages) can still be displayed without the notice.
  • The notice is not being displayed in an overlay.
  • When the notice is displayed, no other parts of the page are visible.

Background:

  • The Twig variable page_works_without_js is being used to determine, whether to show the notice or not. It is being set to true in the template that is used for the page/ route.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Pablo-WMDE moved this task from Sprint ready to Blocked on the WMDE-Fundraising-Tech board.
kai.nissen moved this task from Blocked to Backlog on the WMDE-Fundraising-Tech board.
kai.nissen edited subscribers, added: kai.nissen; removed: Pablo-WMDE.
kai.nissen lowered the priority of this task from High to Medium.Mar 28 2018, 9:49 AM
kai.nissen updated the task description. (Show Details)
gabriel-wmde renamed this task from No JS causes "Could not load no JS notice!" overlay to No JS causes "Could not load no JS notice!" overlay in 10h16 skin.Aug 29 2018, 11:37 AM

This will be obsolete when T185569: Remove 10h16 skin is done.