Page MenuHomePhabricator
Create Task
Maniphest T163455

When mediawiki is in maintenance mode (read only), visual editor shows unparsed wikitext if the wiki has over-ridden the default message with a worse one
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Put English Wikipedia in read only mode with: https://gerrit.wikimedia.org/r/#/c/346251/3/wmf-config/db-eqiad.php
  2. Edit any page (I used what I think is the source version of the visual editor, but I would assume it works similary in all options (the message is nice on the old source editor)
  3. Hit save
  4. Ugly json is shown, instead of pretty explanation that mediawiki is in read only, and the message why.

Suggested patch:

Probably a bit of json parsing the error + CSS would be more than enough.

Details

SubjectRepoBranchLines +/-
ve.init.mw.ArticleTarget: Use a simpler error message when site is read-onlymediawiki/extensions/VisualEditormaster+4 -5
Customize query in gerrit

Related Objects

Event Timeline

jcrespo created this task.Apr 20 2017, 3:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2017, 3:44 PM
matmarex subscribed.Apr 20 2017, 4:50 PM

It looks like that configuration change should be mostly equivalent to setting setting $wgReadOnly = 'foo bar'; locally.

But I can't reproduce this. Instead, trying to save changes results in infinitely repeating requests for action=query&meta=tokens and action=visualeditoredit (which fails with 'badtoken')…

Any chance you saved the exact error message?

jcrespo added a comment.Apr 20 2017, 4:55 PM

Any chance you saved the exact error message?

I kept the browser open, but we had worse issues and finally forgot to get a screnshot. But we can reproduce it again in 2 weeks in the next switchover. I just remember it gave an error and printed the json instead of parsing it and put it "pretty".

matmarex claimed this task.Apr 20 2017, 7:46 PM

My infinite loop issue is T163492/T163493. But I can't reproduce this problem if that is worked around. I get a pretty error message:

image.png (968×1 px, 119 KB)

jcrespo added a comment.EditedApr 20 2017, 8:00 PM

No, I am 99% sure we got JSON there and not "that pretty". Maybe different backend or something? I do not think this is a big deal, I only reported it because it looked like an easy to solve issue (pure cosmetics).

matmarex added a comment.Apr 20 2017, 8:25 PM

Yeah, it must be some difference between my local setup and our production setup, I'm just saying that I can't reproduce it myself and without any hint as to what the actual error/JSON displayed was, I can do nothing about it right now. I guess someone else could try? Best I can do is to be around during the production read-only time during the switchover in two weeks, and try to reproduce then.

matmarex changed the task status from Open to Stalled.Apr 20 2017, 8:44 PM
Anomie subscribed.Apr 20 2017, 8:58 PM

You could try using the 'readonly' option of X-Wikimedia-Debug to reproduce it.

Jdforrester-WMF triaged this task as High priority.Apr 20 2017, 8:59 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF added a project: VisualEditor-MediaWiki.
matmarex changed the task status from Stalled to Open.Apr 20 2017, 9:04 PM

Oh, that's neat, I didn't realize it's an option. In production I get this:

image.png (968×1 px, 202 KB)

…that's not JSON, that's just your friendly MediaWiki template syntax ;) It comes from https://en.wikipedia.org/w/index.php?title=MediaWiki:Readonlywarning&action=edit.

So we need to either convince the English Wikipedia community that they don't need all this crap, or make VisualEditor parse the error message using the real PHP parser rather than client-side jQueryMsg.

Jdforrester-WMF renamed this task from When mediawiki is in maintenance mode (read only), visual editor shows non-user-friendly json with the error to When mediawiki is in maintenance mode (read only), visual editor shows unparsed wikitext if the wiki has over-ridden the default message with a worse one.Apr 20 2017, 9:05 PM
matmarex added a comment.Apr 20 2017, 10:08 PM

(As a side note, the "Review your changes" button in the dialog footer shouldn't overlap the error message. That's T163504.)

gerritbot subscribed.Apr 20 2017, 10:09 PM

Change 349340 had a related patch set uploaded (by Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.init.mw.ArticleTarget: Use a simpler error message when site is read-only

https://gerrit.wikimedia.org/r/349340

gerritbot added a project: Patch-For-Review.Apr 20 2017, 10:10 PM
matmarex added a comment.Apr 20 2017, 10:10 PM

After the patch:

image.png (968×1 px, 111 KB)

gerritbot added a comment.Apr 20 2017, 10:34 PM

Change 349340 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.init.mw.ArticleTarget: Use a simpler error message when site is read-only

https://gerrit.wikimedia.org/r/349340

Jdforrester-WMF closed this task as Resolved.Apr 20 2017, 10:40 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 20 2017, 10:40 PM
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)).Apr 20 2017, 11:00 PM
jcrespo mentioned this in T194939: Announce read-only time on-wiki to users of frwiki, ruwiki and jawiki (May 29, 2018).May 24 2018, 6:57 AM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL