Page MenuHomePhabricator
Create Task
Maniphest T163487

Newsletter extension should use phpcs to enforce mediawiki coding standards.
Closed, ResolvedPublic
Actions

Description

phpcs is currently disabled. It should be enabled.

Details

SubjectRepoBranchLines +/-
Enforce MW coding convention with phpcsmediawiki/extensions/Newslettermaster+76 -37
Some style fixes to better match MW coding conventionsmediawiki/extensions/Newslettermaster+333 -335
Customize query in gerrit

Event Timeline

Bawolff created this task.Apr 20 2017, 7:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2017, 7:32 PM
gerritbot subscribed.Apr 20 2017, 7:56 PM

Change 349281 had a related patch set uploaded (by Brian Wolff):
[mediawiki/extensions/Newsletter@master] Some style fixes to better match MW coding conventions

https://gerrit.wikimedia.org/r/349281

gerritbot added a project: Patch-For-Review.Apr 20 2017, 7:56 PM

Change 349282 had a related patch set uploaded (by Brian Wolff):
[mediawiki/extensions/Newsletter@master] Enforce MW coding convention with phpcs

https://gerrit.wikimedia.org/r/349282

Qgil moved this task from Backlog to Security Review (production blockers) on the MediaWiki-extensions-Newsletter board.Apr 21 2017, 10:14 AM
gerritbot added a comment.May 12 2017, 9:31 PM

Change 349281 merged by jenkins-bot:
[mediawiki/extensions/Newsletter@master] Some style fixes to better match MW coding conventions

https://gerrit.wikimedia.org/r/349281

Qgil triaged this task as Medium priority.May 15 2017, 12:59 PM
01tonythomas assigned this task to Bawolff.May 20 2017, 8:53 AM
01tonythomas subscribed.

@Bawolff < should be resolved> ?

gerritbot added a comment.May 20 2017, 10:01 AM

Change 349282 merged by jenkins-bot:
[mediawiki/extensions/Newsletter@master] Enforce MW coding convention with phpcs

https://gerrit.wikimedia.org/r/349282

01tonythomas closed this task as Resolved.May 20 2017, 10:02 AM

@Bawolff said this should be a good to go after https://gerrit.wikimedia.org/r/349282

Qgil awarded a token.May 22 2017, 4:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL