Page MenuHomePhabricator
Create Task
Maniphest T163504

Action buttons in the footer of a ProcessDialog showing an error are still clickable
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Action buttons in the footer of a ProcessDialog showing an error are still clickable. Clicking the action results in weird and funny things happening, in particular the error message is not closed.

They used to be unclickable, here's a random old version of the demo you can confirm this with: https://doc.wikimedia.org/oojs-ui/v0.12.8/demos/#dialogs-mediawiki-mixed-ltr

For example:

  • "Broken dialog (error handling)" example in the demos:
    image.png (968×1 px, 104 KB)
  • Save dialog in VisualEditor:
    image.png (968×1 px, 128 KB)

Details

SubjectRepoBranchLines +/-
ProcessDialog: Display error messages on top of footer action buttonsoojs/uimaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Apr 20 2017, 8:55 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptApr 20 2017, 8:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdforrester-WMF triaged this task as High priority.Apr 20 2017, 8:57 PM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF added a project: Regression.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
matmarex claimed this task.Apr 20 2017, 8:57 PM
matmarex mentioned this in T163455: When mediawiki is in maintenance mode (read only), visual editor shows unparsed wikitext if the wiki has over-ridden the default message with a worse one.Apr 20 2017, 10:08 PM
matmarex added a comment.Apr 20 2017, 10:18 PM

Caused by rGOJUc8a4e49a31f9: MediaWiki theme: Fix focus states of ActionWidget's buttons.

gerritbot subscribed.Apr 20 2017, 10:37 PM

Change 349346 had a related patch set uploaded (by Bartosz Dziewoński):
[oojs/ui@master] ProcessDialog: Display error messages on top of footer action buttons

https://gerrit.wikimedia.org/r/349346

gerritbot added a project: Patch-For-Review.Apr 20 2017, 10:37 PM
gerritbot added a comment.Apr 20 2017, 11:05 PM

Change 349346 merged by jenkins-bot:
[oojs/ui@master] ProcessDialog: Display error messages on top of footer action buttons

https://gerrit.wikimedia.org/r/349346

Volker_E closed this task as Resolved.Apr 21 2017, 4:43 PM
Volker_E moved this task from Backlog to OOjs-UI-0.21.2 on the OOUI board.
Volker_E edited projects, added OOUI (OOjs-UI-0.21.2); removed OOUI.
Volker_E removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 21 2017, 4:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL