Page MenuHomePhabricator

Action buttons in the footer of a ProcessDialog showing an error are still clickable
Closed, ResolvedPublic1 Story Points

Description

Action buttons in the footer of a ProcessDialog showing an error are still clickable. Clicking the action results in weird and funny things happening, in particular the error message is not closed.

They used to be unclickable, here's a random old version of the demo you can confirm this with: https://doc.wikimedia.org/oojs-ui/v0.12.8/demos/#dialogs-mediawiki-mixed-ltr

For example:

  • "Broken dialog (error handling)" example in the demos:
  • Save dialog in VisualEditor:

Details

Event Timeline

matmarex created this task.Apr 20 2017, 8:55 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptApr 20 2017, 8:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdforrester-WMF triaged this task as High priority.Apr 20 2017, 8:57 PM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF added a project: Regression.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
matmarex claimed this task.Apr 20 2017, 8:57 PM

Change 349346 had a related patch set uploaded (by Bartosz Dziewoński):
[oojs/ui@master] ProcessDialog: Display error messages on top of footer action buttons

https://gerrit.wikimedia.org/r/349346

Change 349346 merged by jenkins-bot:
[oojs/ui@master] ProcessDialog: Display error messages on top of footer action buttons

https://gerrit.wikimedia.org/r/349346

Volker_E closed this task as Resolved.Apr 21 2017, 4:43 PM
Volker_E moved this task from Backlog to OOjs-UI-0.21.2 on the OOUI board.
Volker_E edited projects, added OOUI (OOjs-UI-0.21.2); removed OOUI.
Volker_E removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 21 2017, 4:43 PM