MediawikiApi::newFromPage() fails on non-XML HTML
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Samwilson
	Apr 21 2017, 2:13 AM

Description

When fetching with $api = MediawikiApi::newFromPage('https://sq.wikinews.org/'); I get the following error:

"String could not be parsed as XML" at /vendor/addwiki/mediawiki-api-base/src/MediawikiApi.php line 80
Warning: SimpleXMLElement::__construct(): Entity: line 419: parser error:
Entity 'reg' not defined at vendor/addwiki/mediawiki-api-base/src/MediawikiApi.php:80

I guess newFromPage should be changed to not treat HTML as XML and not use SimpleXml.

Related Objects

Mentioned In: T163634: Pages created interface gives error for most projects in new XTools
T162754: Create XTools API with namespace endpoint, using JS to update to namespace selector
Mentioned Here: T162754: Create XTools API with namespace endpoint, using JS to update to namespace selector

Event Timeline

Samwilson created this task.Apr 21 2017, 2:13 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 21 2017, 2:13 AM

Samwilson added projects: XTools, Community-Tech.Apr 21 2017, 2:16 AM

I noticed this too, which effects T162754. Currently you can't select a number of projects, including es.wikipedia.org

• MusikAnimal mentioned this in T162754: Create XTools API with namespace endpoint, using JS to update to namespace selector.Apr 21 2017, 4:27 PM

Here's a fix: https://github.com/addwiki/mediawiki-api-base/pull/34

The parsing of the RSD XML can still be done with SimpleXml, but perhaps this should be changed too, to be more uniform. What do you think? It's just a few extra lines of code, is all.

Samwilson moved this task from Ready to Needs Review/Feedback on the Community-Tech-Sprint board.Apr 24 2017, 5:50 AM

Addshore subscribed.Apr 24 2017, 3:49 PM

kaldari moved this task from Needs Review/Feedback to In Development on the Community-Tech-Sprint board.Apr 24 2017, 6:45 PM

kaldari mentioned this in T163634: Pages created interface gives error for most projects in new XTools.

Samwilson moved this task from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.Apr 26 2017, 1:52 AM

kaldari closed this task as Resolved.Apr 26 2017, 10:10 PM

kaldari claimed this task.

Now we just need to wait for Addshore to cut a new version.

kaldari moved this task from Needs Review/Feedback to Q1 2018-19 on the Community-Tech-Sprint board.Apr 26 2017, 10:17 PM

Addshore moved this task from In Progress to Done on the Addwiki board.Apr 27 2017, 3:41 PM

In T163527#3216021, @kaldari wrote:

Now we just need to wait for Addshore to cut a new version.

2.3.0 now released :)

@Addshore: Thanks!!

Maybe I'm doing something wrong, but on the latest mediawiki-api and mediawiki-api-core, with MediawikiApi::newFromPage('https://sq.wikinews.org/'); I now get:

Warning: DOMDocument::loadHTML(): ID n-Dhuroni already defined in Entity, line: 370

The backtrace points to https://github.com/addwiki/mediawiki-api-base/blob/master/src/MediawikiApi.php#L87

Anyone else have this issue?

Duplicate element IDs break DOMDocument::loadHTML (in the case above, https://sq.wikinews.org/wiki/MediaWiki:Sidebar contains sitesupport-url|Dhuroni twice). This can be fixed by working around libxml errors (because this one doesn't actually stop the xpath finding the RSD URL, so can be ignored).

I'll send another PR.