Page MenuHomePhabricator

Make it easy to verify that video/firstVisualChange is correct
Closed, DeclinedPublic

Description

Multiple times we have collected wrong firstVisualChange from the video:

  • T163199 - Password bubble and loading bar
  • T135482 - Loading bar
  • T129735 - First view content messed up second view

This happen again and it's hard to automate it in WebPageTest or whatever tool we use to calculate firstVisualChange. It has been changes in Chrome that has caused the problem some of the times.

There's two ways to tackle this:

  1. Make easier to check the screenshots of the runs. Now you need to go to our test instance, find the test, click on the test, go to one run and then choose filmstrip view. We could extract the images and have one page that shows the latest X runs filmstrips and we could easily verify them.
  2. We could setup an alert that alerts if the metrics are too unrealistic fast. Need to think about alert values but should be possible by looking at what kind of value we have seen before.

Event Timeline

Peter triaged this task as Medium priority.May 30 2017, 9:39 AM

Add an alert: If firstVisualChange is too low (eg, before 100ms, or whatever)

Imarlier lowered the priority of this task from Medium to Low.Jun 21 2018, 10:11 AM

I think we will not do this: 1.There was a long time there was an failure 2. It's better to focus on adding automated alerts for the rest of the wikis we test.