If I go to fill out an application for Taylor & Francis (https://wikipedialibrary.wmflabs.org/applications/apply/10/), I should only be able to select from their 3 collections, but I can select any, including those from other partners.
Description
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | jsn.sherman | T147434 Version 1.5: Beta fixes | |||
Resolved | jsn.sherman | T163579 Any collection can be selected for an application to a specific partner |
Event Timeline
after noodling around on this for a bit, I can tell you that it won't be a trivial fix. The bit of code that touches on this is the helper function that statically defines a bunch of things so that other parts of the application process can be dynamic. We basically need to make a part of *that* dynamic to fix the bug. I'm going to let this one marinate for a little while to think about the best way to tackle it.
@Samwalton9 I've cut a 1st cut of the fix on staging. The problem is essentially solved, but it will need a little cleanup and testing before it goes to prod.
Hmm. I still seem to be able to select any collections. (e.g. https://twl-test.wmflabs.org/applications/apply/10/)
That's the live website. You want
https://twlight-staging.wmflabs.org/applications/apply/10/