Page MenuHomePhabricator

Make a list of downloadable compilations searchable
Closed, ResolvedPublic

Description

This tasks means searching by title as in the current reading list implementation. Search will not consider page content.

QA steps to test

  1. Open "Offline Compilations" from the Explore feed overflow menu and select to add a compilation
  2. Upon opening screen showing all available compilations, tap on the search icon in the toolbar
  3. Type in something to see the expected result that the list is being filtered to show the matching compilation titles.

Event Timeline

Change 367705 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Populate remote compilations with response from CompilationClient.

https://gerrit.wikimedia.org/r/367705

Change 367705 merged by jenkins-bot:
[apps/android/wikipedia@master] Populate remote compilations with response from CompilationClient.

https://gerrit.wikimedia.org/r/367705

RHo added a subscriber: RHo.

Hi @Dbrant, just a couple of visual design tweaks and then good to go:

  • status bar background color should be a darker shade to the toolbar color
  • background color of the article pack list item is #FFF (not the Base90 color)
  • background color of the screen is #EAECF0 aka Base80 (not the Base90 color)

main-MainActivity-08092017152554.png (1×1 px, 146 KB)

@RHo Regarding the background color of the screen: should this be defined as the standard background color for all screens? (e.g. reading lists, history, login, settings, etc) And what are the corresponding colors for dark mode?

yes that is so. Per T165415 the standard background color for Light mode should be Base20, and for Dark should be Base10.

So then, does this mean that the background color for list items is defined as "Paper background"?

Reposting comment from earlier so visual design tweaks required are clear:

  • status bar background color should be a darker shade to the toolbar color
  • background color of the article pack list item is #FFF (not the Base90 color)
  • background color of the screen is #EAECF0 aka Base80 (not the Base90 color)
  • new thumbnail should NOT have a border, and background color is #FFF
Expected
A03iii - All available as standalone 'store'.png (1×720 px, 139 KB)
Actual
main-MainActivity-08092017152554.png (1×1 px, 146 KB)

Change 380978 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Design tweaks: download progress widget updates.

https://gerrit.wikimedia.org/r/380978

Change 380978 merged by jenkins-bot:
[apps/android/wikipedia@master] Design tweaks: download progress widget updates.

https://gerrit.wikimedia.org/r/380978

LGTM

image.png (1×1 px, 223 KB)

Tested on Nexus (6.0.1), Wikipedia v2.6.203-alpha-2017-10-12

Reposting comment from earlier so visual design tweaks required are clear:
status bar background color should be a darker shade to the toolbar color
background color of the article pack list item is #FFF (not the Base90 color)
background color of the screen is #EAECF0 aka Base80 (not the Base90 color)
new thumbnail should NOT have a border, and background color is #FFF