Page MenuHomePhabricator

Make downloaded/active compilations searchable
Closed, ResolvedPublic

Event Timeline

Searchable - to be able to search them by title, by description. Not by content. Basically, a filter.

There's a separate task to implement the sorting behaviour.

Change 365262 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Introduce activity for managing offline compilations.

https://gerrit.wikimedia.org/r/365262

Change 365262 merged by jenkins-bot:
[apps/android/wikipedia@master] Introduce activity for managing offline compilations.

https://gerrit.wikimedia.org/r/365262

RHo subscribed.

Hi @Dbrant - this is actually not the expected behavior to trigger search of only downloaded article packs via the search in the toolbar. The expected behavior is that it should search the entire Offline library similar to the same way search in the Play store searches the entire store, and both downloaded and not downloaded packs will be shown in the list.

Hmm, so then what's actually the reason for us to have separate activities for looking at "downloaded" vs. "downloadable" packs? Doesn't this imply that we can have a single activity that always shows all the possible packs, and simply mark which ones are currently downloaded?

Ahh, yes agree we could just decline as a dupe of T163590. I think this separate ticket was made when the project was first started and it had not yet been determined how separate the 'article packs store' was to the users downloaded packs.

@Dbrant - can this search on the main Offline Library screen be removed before testing? It is already a point of confusion for the usability folks.

@RHo Agreed -- I doubt anyone will ever download so many packs that they need to "search" through them in their list.

Change 374386 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] No longer allow searching in local packs.

https://gerrit.wikimedia.org/r/374386

Change 374386 merged by jenkins-bot:
[apps/android/wikipedia@master] No longer allow searching in local packs.

https://gerrit.wikimedia.org/r/374386