Page MenuHomePhabricator

Don't watch user page when blocking was not sucessful
Closed, ResolvedPublic


If an error (user already blocked, wrong time format, user doesn't exist, ...) occurs while blocking a user and wpWatchUser is true, the user page is added to the watchlist. IMHO this should only apply if the user was blocked successfully.

Version: 1.13.x
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:12 PM
bzimport set Reference to bz14367.

Created attachment 4945
Quick fix for this, against r35759

Quick patch to implement this. Should've done this originally when I wrote the feature. Now runs after BlockIpComplete, so we know we completed correctly and didn't abort.