Page MenuHomePhabricator
Create Task
Maniphest T16367

Don't watch user page when blocking was not sucessful
Closed, ResolvedPublic
Actions

Description

If an error (user already blocked, wrong time format, user doesn't exist, ...) occurs while blocking a user and wpWatchUser is true, the user page is added to the watchlist. IMHO this should only apply if the user was blocked successfully.

Version: 1.13.x
Severity: normal

Details

Reference
bz14367

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:12 PM
• bzimport added a project: MediaWiki-User-management.
• bzimport set Reference to bz14367.
• adrianheine created this task.May 31 2008, 8:15 PM
• demon added a comment.Jun 2 2008, 8:36 PM

Created attachment 4945
Quick fix for this, against r35759

Quick patch to implement this. Should've done this originally when I wrote the feature. Now runs after BlockIpComplete, so we know we completed correctly and didn't abort.

Attached:

diff.patch836 BDownload

• brooke added a comment.Jun 2 2008, 9:53 PM

Applied on r35763

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits