Page MenuHomePhabricator

Display none should be applied to parent container
Open, Needs TriagePublic

Description

Dismissable SiteNotice is a great extension but not everyone uses it. This makes it hard for a skin developer to account for its use. The problem is the addition of the content containers inside the div id=siteNotice causes a styled siteNotice container to still show. It still has content from Dismissable SiteNotice even if it is hidden. The result is the image attached.

Capture-Hidden-Dismissable-Sitenotice.PNG (118×1 px, 2 KB)

The JS should add the "display none" class on the parent div container of the siteNotice div, not the child div of containing the class .mw-dismissable-notice.