|mediawiki/extensions/MobileFrontend : master||Category overlay should show "content based" categories|
|Declined||None||T124865 Support any default type of pages in the app|
|Open||None||T158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web|
|Open||None||T198313 [GOAL] Advanced mobile contributions|
|Open||None||T24660 [Epic] Display the categories on the mobile site for everyone|
|Resolved||None||T163699 [Regression] Content based categories show up as organization based categories|
Tested and merged the existing patch.
It seems that there may be room for one or two more tests (unit or browser) to verify that hidden and non-hidden categories get shoved into the correct tab.
See comments on https://gerrit.wikimedia.org/r/#/c/349974 :
I wonder if we should split tests into two by distinguishing "content based" and "organizational" categories. I haven't tested manually, but I have a feeling that these tests would pass without the fix in certain situations.
Yup, you are correct. The browser test only ensures results show up on the first screen.
I was tempted to add browser tests for hidden categories too but i was also wary that I'd be investing a lot of time on unplanned sprint work so I limited myself to the bare minimum.
I'm not claiming this will resolve https://phabricator.wikimedia.org/T161050 but it's a good start.
As you both talked about, there may be room for another tests checking hidden vs non-hidden categories.
Moving to needs more work until we have the discussion. This will need QA when finalized.
I've updated T161050 which will be included in a future sprint when we have time to focus on the category/talk features. This seems done to me.
On hindsight given the existence of T161050 "some browser tests" was the inappropriate phrase "a browser test" would have made more sense.
If we feel we should pull T161050 into the sprint and we have bandwidth, let's do that.
Tested at https://en.m.wikipedia.beta.wmflabs.org/wiki/1?mobileaction=beta#/categories. The page belongs to a normal and a hidden category, both are grouped accordingly in the category overlay.