Page MenuHomePhabricator

[Regression] Content based categories show up as organization based categories
Closed, ResolvedPublic2 Story Points

Description

As a result of T162922 although we now show categories we show them under the wrong heading.
Let's introduce some browser tests this time to avoid further regressions.

Details

Related Gerrit Patches:
mediawiki/extensions/MobileFrontend : masterCategory overlay should show "content based" categories

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 24 2017, 3:35 PM

Change 349974 had a related patch set uploaded (by Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Category overlay should show "content based" categories

https://gerrit.wikimedia.org/r/349974

Jdlrobson triaged this task as Normal priority.Apr 24 2017, 5:16 PM
Jdlrobson moved this task from Needs Analysis to Needs Code Review on the Reading-Web-Sprint-96 board.
Jdlrobson set the point value for this task to 2.

@Jdlrobson I've left a comment on the patch in case you didn't get a notification.

Jhernandez added a subscriber: Jhernandez.

Tested and merged the existing patch.

It seems that there may be room for one or two more tests (unit or browser) to verify that hidden and non-hidden categories get shoved into the correct tab.

See comments on https://gerrit.wikimedia.org/r/#/c/349974 :

@bmansurov
I wonder if we should split tests into two by distinguishing "content based" and "organizational" categories. I haven't tested manually, but I have a feeling that these tests would pass without the fix in certain situations.
@Jdlrobson
Yup, you are correct. The browser test only ensures results show up on the first screen.
I was tempted to add browser tests for hidden categories too but i was also wary that I'd be investing a lot of time on unplanned sprint work so I limited myself to the bare minimum.
I'm not claiming this will resolve https://phabricator.wikimedia.org/T161050 but it's a good start.
@Jhernandez
As you both talked about, there may be room for another tests checking hidden vs non-hidden categories.

Moving to needs more work until we have the discussion. This will need QA when finalized.

Change 349974 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Category overlay should show "content based" categories

https://gerrit.wikimedia.org/r/349974

I've updated T161050 which will be included in a future sprint when we have time to focus on the category/talk features. This seems done to me.

On hindsight given the existence of T161050 "some browser tests" was the inappropriate phrase "a browser test" would have made more sense.

If we feel we should pull T161050 into the sprint and we have bandwidth, let's do that.

Jdlrobson removed Jdlrobson as the assignee of this task.Apr 26 2017, 3:53 PM

Someone other than me should sign this off. Any takers?

phuedx assigned this task to bmansurov.Apr 26 2017, 5:05 PM
bmansurov closed this task as Resolved.Apr 26 2017, 6:39 PM
bmansurov removed bmansurov as the assignee of this task.

Tested at https://en.m.wikipedia.beta.wmflabs.org/wiki/1?mobileaction=beta#/categories. The page belongs to a normal and a hidden category, both are grouped accordingly in the category overlay.