Page MenuHomePhabricator

" Highlight likely problem edits with colors and an "r" for "needs review"" shows up even with RC Filters beta feature enabled
Closed, InvalidPublic

Description

The " Highlight likely problem edits with colors and an "r" for "needs review"" preference (under Watchlist) is supposed to show only with the RC Filters Beta Feature disabled, but it seems to (usually?) show either way.

Event Timeline

Restricted Application added a project: Scoring-platform-team. · View Herald TranscriptApr 24 2017, 4:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Furthermore, @jmatazzoni reports that he (correctly) does not see the preference, but that it (incorrectly) behaves as if it's set to true. Hidden preferences should behave as if they are set to their defaults, and the default is false.

Change 349987 had a related patch set uploaded (by Catrope):
[mediawiki/extensions/ORES@master] Hack around the fact that setting $wgHiddenPrefs from GetPreferences doesn't fully work

https://gerrit.wikimedia.org/r/349987

Change 349987 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Hack around the fact that setting $wgHiddenPrefs from GetPreferences doesn't fully work

https://gerrit.wikimedia.org/r/349987

For testing, just to make sure we get everything, here are the all the parts turning off the new functionality for "Highlight likely problem edits with colors and an "r" on the RC Page prefs when the new beta is on (as per T163025):

Users with the New Filters for Edit Review can not have this option. For anyone who has the New Filters or anyone who opts into it:

  1. Turn off the shading
  2. Turn off the "r"
  3. Remove the option from RC Page preferences preferences.
  4. But save the preference information and reinstate the preference if they turn off the New Filters beta. (If this last can't be easily done, it's not critical.)

Change 350010 had a related patch set uploaded (by Mattflaschen; owner: Catrope):
[mediawiki/extensions/ORES@wmf/1.29.0-wmf.20] Hack around the fact that setting $wgHiddenPrefs from GetPreferences doesn't fully work

https://gerrit.wikimedia.org/r/350010

Change 350010 merged by jenkins-bot:
[mediawiki/extensions/ORES@wmf/1.29.0-wmf.20] Hack around the fact that setting $wgHiddenPrefs from GetPreferences doesn't fully work

https://gerrit.wikimedia.org/r/350010

Mattflaschen-WMF closed this task as Invalid.Apr 26 2017, 10:20 PM

Turns out it is supposed to do what I said in the description.

However, there is also another preference in Recent changes, which does have the correct hide/unhide behavior.