Page MenuHomePhabricator

Update appearance of TablePager nav component
Closed, ResolvedPublic


TablePager is a PHP widget in core, used all over the place, e.g. on and

image.png (51×376 px, 6 KB)
image.png (54×506 px, 4 KB)

Shown in context:

image.png (361×1 px, 34 KB)

Event Timeline

Probably a button group widget, maybe with better icons:

image.png (41×462 px, 4 KB)

@Esanders @matmarex was telling me months ago, that he doesn't see OOjs UI as component there.
Anyways, my original idea was to stay with frameless buttons, maybe in a special styling (labels below).

I'm not sure what I was thinking months ago, but right now I have no strong feelings about this, as long as we're talking about just these buttons/links shown on the screenshot (TablePager::getNavigationBar()). TablePager also includes code for generating the entire table show on these pages, and I feel that should not be an OOjs UI widget. It's just a table.

Esanders renamed this task from Update appearance of TablePager component to Update appearance of TablePager nav component.Apr 24 2017, 6:01 PM

Change 349997 had a related patch set uploaded (by Esanders):
[mediawiki/core@master] WIP OOUI-ificiation of TablePager nav

Ideally we'd use different icons for first & previous (and last and next), but we don't have them in the OOUI icon set…

Yes, that's what I meant by "better icons"

Change 351604 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Add first/last icons to complement previous/next

Change 351604 merged by jenkins-bot:
[oojs/ui@master] icons: Add first/last to complement previous/next in movement pack

Change 349997 merged by jenkins-bot:
[mediawiki/core@master] OOUI-ificiation of TablePager nav

Jdforrester-WMF updated the task description. (Show Details)