Page MenuHomePhabricator

Clearing all history items causes up-and-to-right animation.
Closed, ResolvedPublic

Description

This differs from Saved pages clear all animation.

Event Timeline

JMinor triaged this task as Lowest priority.May 1 2017, 6:59 PM
JMinor added a project: good first task.

Tested Wikipedia app 5.4.1 (1124) on iPhone 6S (iOS 10.3.1) and iPhone 7 (iOS 10.3.2), this is not fixed yet.

ABorbaWMF subscribed.

I also did not see a difference between clearing saved and history on App 5.5.0 (1129).

Confirmed it's not yet in 1132 either. Should go out in next build.

@NHarateh_WMF I'm not sure it made it. I tested on App 5.5.0 (1134) and the I still don't see a difference in the animation between clearing saved pages and history. This is on White Beta.

Thanks for the ping @ABorbaWMF , I'll move this to blocked for now and when I'm able to access the latest build, I'll quickly check if it looks like it's there and let you know so that it can be properly tested :)

I also did not see a difference between clearing saved and history on App 5.5.0 (1129).

I'm not sure it made it. I tested on App 5.5.0 (1134) and the I still don't see a difference in the animation between clearing saved pages and history. This is on White Beta.

@ABorbaWMF @NHarateh_WMF ^ that's the expected behavior. The bug was that clearing history looked different from clearing saved. This can be moved to PM signoff.

(I also verified that clearing history works properly on 5.5.0 (1134))

Thanks for catching that @JoeWalsh , seems like it's ready to move to signoff @ABorbaWMF

Oh jeez. Sorry I totally missed that. Sorry @JoeWalsh