Page MenuHomePhabricator

Fix email notifications from LoginNotify
Closed, ResolvedPublic3 Estimated Story Points

Description

Currently the email notifications from Login Notify look like this:

There have been multiple failed login attempts to your account. Please make sure your account has a strong password.

:  <>

Change password:  <http://core.local/index.php/Special:ChangePassword>

Looks like there's a designated spot for the primary link which doesn't have anything in it. We may need to override this in the PresentationModel.

Event Timeline

kaldari triaged this task as High priority.Apr 24 2017, 9:02 PM
kaldari edited projects, added Community-Tech; removed Community-Tech-Sprint.
kaldari moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.
DannyH set the point value for this task to 3.Apr 25 2017, 11:16 PM

Change 350889 had a related patch set uploaded (by Niharika29; owner: Niharika29):
[mediawiki/extensions/LoginNotify@master] Fix broken LoginNotify emails

https://gerrit.wikimedia.org/r/350889

Better email:

Subject: Multiple failed attempts to log in to devwiki as Test1
----

There have been have been 4 failed attempts to log in to your account since the last time you logged in. If it wasn't you, please make sure your account has a strong password.


Help information:  <https://mediawiki.org/wiki/Help:Login_notifications?markasread=3D191>

Change password:  <http://dev.wiki.local.wmftest.net:8080/wiki/Special:ChangePassword>

--

To control which emails we send you, check your preferences:
http://dev.wiki.local.wmftest.net:8080/wiki/Special:Preferences#mw-prefsection-echo

(This was when my threshold was set to 4 on my local instance)

Here's what the email notifications look like now:

There has been a failed attempt to log in to your account from a new device. Please make sure your account has a strong password.

Help information:  <https://mediawiki.org/wiki/Help:Login_notifications?markasread=60>

Change password:  <http://core.local/index.php/Special:ChangePassword>

Change 350889 merged by jenkins-bot:
[mediawiki/extensions/LoginNotify@master] Fix broken LoginNotify emails

https://gerrit.wikimedia.org/r/350889