Page MenuHomePhabricator
Create Task
Maniphest T163749

[wmf.21-regression] Posting a reply to Flow topics with multiple posts redirects users to no-js mode
Closed, ResolvedPublic
Actions

Description

In testwiki wmf.21 and betalabs.

  1. In betalabs on Flow board look for a topic that has more than one Reply
  2. On a Flow topic with multiple posts, click to 'Reply' on the first Reply link or on any but not the last. You will be redirected to the Permalink of that topic and there will be no VE option in the Reply area.

So, instead of being presented with this

Screen Shot 2017-04-24 at 2.58.11 PM.png (416×1 px, 47 KB)

a user is redirected to Permalink for this topic and Reply area won't have VE option ('Cancel' button is also not red). It looks like no-js mode behavior (almost, since 'Cancel' button is still present )
Screen Shot 2017-04-24 at 3.07.19 PM.png (494×1 px, 50 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Follow-up c1beac48: fix JS error when clicking reply linkmediawiki/extensions/Flowwmf/1.29.0-wmf.21+14 -15
Follow-up c1beac48: fix JS error when clicking reply linkmediawiki/extensions/Flowmaster+14 -15
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Apr 24 2017, 10:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 24 2017, 10:07 PM
Etonkovidova updated the task description. (Show Details)Apr 24 2017, 10:08 PM
Etonkovidova renamed this task from [betalabs-regression] Posting a reply to Flow topics with multiple posts redirects users to no-js mode to [wmf.21-regression] Posting a reply to Flow topics with multiple posts redirects users to no-js mode.Apr 25 2017, 10:56 PM
Etonkovidova updated the task description. (Show Details)
Etonkovidova updated the task description. (Show Details)
Catrope subscribed.Apr 25 2017, 11:26 PM

Caused by a JS error: Cannot read property 'append' of undefined in mw.flow.ui.ReplyWidget.prototype.intializeEditor where it does this.$editorContainer.append(this.editor.$element); (this.$editorContainer is undefined)

gerritbot subscribed.Apr 25 2017, 11:44 PM

Change 350331 had a related patch set uploaded (by Catrope):
[mediawiki/extensions/Flow@master] Follow-up c1beac48: fix JS error when clicking reply link

https://gerrit.wikimedia.org/r/350331

gerritbot added a project: Patch-For-Review.Apr 25 2017, 11:44 PM
gerritbot added a comment.Apr 25 2017, 11:56 PM

Change 350331 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Follow-up c1beac48: fix JS error when clicking reply link

https://gerrit.wikimedia.org/r/350331

gerritbot added a comment.Apr 25 2017, 11:57 PM

Change 350334 had a related patch set uploaded (by Catrope):
[mediawiki/extensions/Flow@wmf/1.29.0-wmf.21] Follow-up c1beac48: fix JS error when clicking reply link

https://gerrit.wikimedia.org/r/350334

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)).Apr 26 2017, 12:00 AM
gerritbot added a comment.Apr 26 2017, 12:12 AM

Change 350334 merged by jenkins-bot:
[mediawiki/extensions/Flow@wmf/1.29.0-wmf.21] Follow-up c1beac48: fix JS error when clicking reply link

https://gerrit.wikimedia.org/r/350334

Stashbot subscribed.Apr 26 2017, 12:20 AM

Mentioned in SAL (#wikimedia-operations) [2017-04-26T00:20:47Z] <catrope@naos> Synchronized php-1.29.0-wmf.21/extensions/Flow/modules/flow/ui/widgets/mw.flow.ui.ReplyWidget.js: T163749 (duration: 01m 24s)

Catrope edited projects, added MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), StructuredDiscussions, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017); removed MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), Collaboration-Team-Triage.Apr 26 2017, 12:33 AM
Catrope moved this task from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Etonkovidova added a comment.EditedApr 26 2017, 6:57 PM

Checked the fix in betalabs and testwiki (wmf.21).

QA Recommendation: Resolve

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.Apr 26 2017, 6:58 PM
• jmatazzoni closed this task as Resolved.May 3 2017, 4:59 PM
• jmatazzoni claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits