App terminates when tapping search
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	• Niedzielski
	Apr 24 2017, 11:34 PM

Description

Stack trace

java.lang.NullPointerException: Attempt to invoke virtual method 'void android.widget.ListView.setSelectionAfterHeaderView()' on a null object reference
	at org.wikipedia.search.SearchResultsFragment$2$1.run(SearchResultsFragment.java:258)
	at android.os.Handler.handleCallback(Handler.java:751)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:154)
	at android.app.ActivityThread.main(ActivityThread.java:6121)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)

https://rink.hockeyapp.net/manage/apps/226650/app_versions/94/crash_reasons/166330480
https://play.google.com/apps/publish/?account=6169333749249604352#ReviewDetailsPlace:p=org.wikipedia&reviewid=gp:AOqpTOFMaSiG2OSHAHbYNPZI0-84Rsm2UD1-9f5mrNDNVm8Iy60N_rmKtZpipqCeKR4xMVZpZFPIRoOiKr1g

Environments observed

App version: 2.5.195
Android OS versions: Android 7.1
Device model: d855
Device language: English

Details

	Subject	Repo	Branch	Lines +/-
	Fix: prevent possible crash when invoking search.	apps/android/wikipedia	master	+3 -0

Customize query in gerrit

Event Timeline

• Niedzielski created this task.Apr 24 2017, 11:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 24 2017, 11:34 PM

• Niedzielski updated the task description. (Show Details)Apr 24 2017, 11:36 PM

• Niedzielski updated the task description. (Show Details)Apr 25 2017, 2:18 AM

Dan653 subscribed.Apr 25 2017, 2:25 AM

Dan653 added a project: iOS-app-Bugs.Apr 25 2017, 2:38 AM

Dan653 updated the task description. (Show Details)

Restricted Application added a project: Wikipedia-iOS-App-Backlog. · View Herald TranscriptApr 25 2017, 2:38 AM

@Dan653 This task describes the crash in the Android app only. If you observe similar behavior in the iOS app, please create a separate task.

Change 350208 had a related patch set uploaded (by Dbrant):
[apps/android/wikipedia@master] Fix: prevent possible crash when invoking search.

https://gerrit.wikimedia.org/r/350208

gerritbot added a project: Patch-For-Review.Apr 25 2017, 2:00 PM

Change 350208 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix: prevent possible crash when invoking search.

https://gerrit.wikimedia.org/r/350208

Dan653 updated the task description. (Show Details)Apr 25 2017, 2:47 PM

Dan653 unsubscribed.

Dbrant edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴); removed Wikipedia-Android-App-Backlog.Apr 26 2017, 3:17 PM

Dbrant moved this task from To Do to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.

Dbrant moved this task from Android-app-release-v2.6.19x-Bermuda🌴 to Bug Backlog on the Wikipedia-Android-App-Backlog board.

Dbrant edited projects, added Wikipedia-Android-App-Backlog; removed Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴).

• NHarateh_WMF edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴); removed Wikipedia-Android-App-Backlog.May 3 2017, 3:21 PM

The TSG office doesn't have an Android 7 device right now, however on Samsung Galaxy Express 3 (J120A) with Android 6.0.1 and the latest app build 2.5.195-alpha-2017-05-05 there are no issues with crashing when tapping Search.

Tested on Nexus 4 Android 5.1 and Pixel Android 7.1.1 both on 2.5.195-alpha-2017-05-11

I have the pixel on 7.1.1 and I did a bunch of searching yesterday and today. I think this one is fixed.

Dbrant moved this task from Ready for Signoff to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.May 15 2017, 3:10 PM

Dbrant closed this task as Resolved.May 15 2017, 3:11 PM

Dbrant claimed this task.

App terminates when tapping searchClosed, ResolvedPublic1 Estimated Story PointsActions