[Task] Release DataValues Geo 2.0.0
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	thiemowmde
	Apr 25 2017, 10:28 AM

Description

With T161231 we changed the GlobeCoordinateValue hashing, which technically is a breaking change and requires a major version bump. There are two other breaking changes waiting for a long time. I suggest to include them into this release.

Patch-For-Review:

https://github.com/DataValues/Geo/pull/53 adds missing sanity checks to GlobeCoordinateValue.
https://github.com/DataValues/Geo/pull/23 changes all confusing "GeoCoordinate…" class names to "LatLong…".
https://github.com/DataValues/Geo/pull/103 adds release notes.
Create a 2.0.0 tag.
Make sure https://packagist.org/packages/data-values/geo got it, and update manually if not.
Update Wikibase.git to use the new version.

Details

	Subject	Repo	Branch	Lines +/-
	Bump data-values/geo version requirement to 2.0.0	mediawiki/extensions/Wikibase	master	+45 -46

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	thiemowmde	T165123 [Task] Update all DataValues Geo dependencies to 2.0
Resolved	thiemowmde	T163775 [Task] Release DataValues Geo 2.0.0
Resolved	thiemowmde	T161231 Hashes of globe-coordinates are sensitive to serialize_precision ini setting.

Event Timeline

thiemowmde created this task.Apr 25 2017, 10:28 AM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptApr 25 2017, 10:28 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

thiemowmde triaged this task as Medium priority.Apr 25 2017, 10:28 AM

thiemowmde added a subtask: T161231: Hashes of globe-coordinates are sensitive to serialize_precision ini setting..

thiemowmde added a project: Patch-For-Review.

thiemowmde moved this task from incoming to in progress on the Wikidata board.

thiemowmde moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.

thiemowmde mentioned this in T161231: Hashes of globe-coordinates are sensitive to serialize_precision ini setting..Apr 25 2017, 10:31 AM

thiemowmde closed subtask T161231: Hashes of globe-coordinates are sensitive to serialize_precision ini setting. as Resolved.

How important it is to release the bug fix from https://github.com/DataValues/Geo/pull/101? It seems important to me (it is a bug after all), so maybe it was worth not to wait for the other changes which as I got are of lower priority and not really critical, but just go ahead and release the new version right away?

I don't think it is critical at the moment. Note that the original issue that justifies this release is about the serialize_precision PHP setting, which I assume is the same on all relevant servers we are using. Otherwise stuff would have been broken long ago. This came up because a local dev machine was set up different.

• Aleksey_WMDE updated the task description. (Show Details)May 8 2017, 11:14 AM

WMDE-leszek updated the task description. (Show Details)May 9 2017, 10:15 AM

Change 353022 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Bump data-values/geo version requirement to 2.0.0

https://gerrit.wikimedia.org/r/353022

WMDE-leszek updated the task description. (Show Details)May 10 2017, 9:34 AM

Change 353022 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Bump data-values/geo version requirement to 2.0.0

https://gerrit.wikimedia.org/r/353022

WMDE-leszek closed this task as Resolved.May 11 2017, 8:14 AM

WMDE-leszek updated the task description. (Show Details)

WMDE-leszek moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.

thiemowmde mentioned this in T165123: [Task] Update all DataValues Geo dependencies to 2.0.May 12 2017, 6:51 AM

thiemowmde added a parent task: T165123: [Task] Update all DataValues Geo dependencies to 2.0.